[SDK-FIX] wrap poller without re-initializing

Author: Chien Yuan Chang

sdk/contentunderstanding/azure-ai-contentunderstanding/azure/ai/contentunderstanding/_patch.py

@@ -217,13 +217,8 @@ def begin_analyze(  # type: ignore[override]  # pyright: ignore[reportIncompatib
                 **kwargs,
             )
 
-        # Wrap in custom poller with .operation_id property
-        return AnalyzeLROPoller(  # pyright: ignore[reportInvalidTypeArguments]
-            self._client,
-            poller._polling_method._initial_response,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method._deserialization_callback,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method,  # pylint: disable=protected-access
-        )
+        # Wrap in custom poller with .operation_id property (without re-initializing)
+        return AnalyzeLROPoller.from_poller(poller)  # pyright: ignore[reportReturnType]
 
     @distributed_trace
     def begin_analyze_binary(
@@ -274,13 +269,8 @@ def begin_analyze_binary(
             **kwargs,
         )
 
-        # Wrap in custom poller with .operation_id property
-        return AnalyzeLROPoller(  # pyright: ignore[reportInvalidTypeArguments]
-            self._client,
-            poller._polling_method._initial_response,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method._deserialization_callback,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method,  # pylint: disable=protected-access
-        )
+        # Wrap in custom poller with .operation_id property (without re-initializing)
+        return AnalyzeLROPoller.from_poller(poller)  # pyright: ignore[reportReturnType]
 
 
 def patch_sdk():

sdk/contentunderstanding/azure-ai-contentunderstanding/azure/ai/contentunderstanding/aio/_patch.py

@@ -217,13 +217,8 @@ async def begin_analyze(  # type: ignore[override]  # pyright: ignore[reportInco
                 **kwargs,
             )
 
-        # Wrap in custom poller with .operation_id property
-        return AnalyzeAsyncLROPoller(  # pyright: ignore[reportInvalidTypeArguments]
-            self._client,
-            poller._polling_method._initial_response,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method._deserialization_callback,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method,  # pylint: disable=protected-access
-        )
+        # Wrap in custom poller with .operation_id property (without re-initializing)
+        return AnalyzeAsyncLROPoller.from_poller(poller)  # pyright: ignore[reportReturnType]
 
     @distributed_trace_async
     async def begin_analyze_binary(
@@ -274,13 +269,8 @@ async def begin_analyze_binary(
             **kwargs,
         )
 
-        # Wrap in custom poller with .operation_id property
-        return AnalyzeAsyncLROPoller(  # pyright: ignore[reportInvalidTypeArguments]
-            self._client,
-            poller._polling_method._initial_response,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method._deserialization_callback,  # type: ignore # pylint: disable=protected-access
-            poller._polling_method,  # pylint: disable=protected-access
-        )
+        # Wrap in custom poller with .operation_id property (without re-initializing)
+        return AnalyzeAsyncLROPoller.from_poller(poller)  # pyright: ignore[reportReturnType]
 
 
 def patch_sdk():

sdk/contentunderstanding/azure-ai-contentunderstanding/azure/ai/contentunderstanding/aio/models/_patch.py

@@ -59,6 +59,24 @@ def operation_id(self) -> str:
         except (KeyError, ValueError) as e:
             raise ValueError(f"Could not extract operation ID: {str(e)}") from e
 
+    @classmethod
+    def from_poller(cls, poller: AsyncLROPoller[PollingReturnType_co]) -> "AnalyzeAsyncLROPoller[PollingReturnType_co]":
+        """Wrap an existing AsyncLROPoller without re-initializing the polling method.
+
+        This avoids duplicate HTTP requests that would occur if we created a new
+        AsyncLROPoller instance (which calls polling_method.initialize() again).
+
+        :param poller: The existing AsyncLROPoller to wrap
+        :type poller: ~azure.core.polling.AsyncLROPoller
+        :return: An AnalyzeAsyncLROPoller wrapping the same polling state
+        :rtype: AnalyzeAsyncLROPoller
+        """
+        # Create instance without calling __init__ to avoid re-initialization
+        instance: AnalyzeAsyncLROPoller[PollingReturnType_co] = object.__new__(cls)
+        # Copy all attributes from the original poller
+        instance.__dict__.update(poller.__dict__)
+        return instance
+
     @classmethod
     async def from_continuation_token(  # type: ignore[override]  # pylint: disable=invalid-overridden-method
         cls,

sdk/contentunderstanding/azure-ai-contentunderstanding/azure/ai/contentunderstanding/models/_patch.py

@@ -90,6 +90,24 @@ def operation_id(self) -> str:
         except (KeyError, ValueError) as e:
             raise ValueError(f"Could not extract operation ID: {str(e)}") from e
 
+    @classmethod
+    def from_poller(cls, poller: LROPoller[PollingReturnType_co]) -> "AnalyzeLROPoller[PollingReturnType_co]":
+        """Wrap an existing LROPoller without re-initializing the polling method.
+
+        This avoids duplicate HTTP requests that would occur if we created a new
+        LROPoller instance (which calls polling_method.initialize() again).
+
+        :param poller: The existing LROPoller to wrap
+        :type poller: ~azure.core.polling.LROPoller
+        :return: An AnalyzeLROPoller wrapping the same polling state
+        :rtype: AnalyzeLROPoller
+        """
+        # Create instance without calling __init__ to avoid re-initialization
+        instance: AnalyzeLROPoller[PollingReturnType_co] = object.__new__(cls)
+        # Copy all attributes from the original poller
+        instance.__dict__.update(poller.__dict__)
+        return instance
+
     @classmethod
     def from_continuation_token(
         cls, polling_method: PollingMethod[PollingReturnType_co], continuation_token: str, **kwargs: Any