Skip to content

Commit 73fda65

Browse files
authored
Quick-Fix-API-Fix (#38818)
* Quick-Fix-API-Fix * adjust perf num
1 parent 5ec5763 commit 73fda65

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_common/_base_eval.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ def _convert_kwargs_to_eval_input(self, **kwargs) -> Union[List[Dict], List[Deri
295295
)
296296
# Handle Conversation
297297
if conversation is not None:
298-
if self.is_multi_modal_conversation(conversation):
298+
if self._is_multi_modal_conversation(conversation):
299299
return self._derive_multi_modal_conversation_converter()(conversation)
300300
return self._derive_conversation_converter()(conversation)
301301
# Handle Singletons
@@ -311,7 +311,7 @@ def _convert_kwargs_to_eval_input(self, **kwargs) -> Union[List[Dict], List[Deri
311311
target=ErrorTarget.CONVERSATION,
312312
)
313313

314-
def is_multi_modal_conversation(self, conversation: Dict) -> bool:
314+
def _is_multi_modal_conversation(self, conversation: Dict) -> bool:
315315
if "messages" not in conversation:
316316
return False
317317
messages = conversation["messages"]

sdk/evaluation/azure-ai-evaluation/tests/unittests/test_evaluate_performance.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def test_bulk_evaluate(self, big_f1_data_file, use_pf_client):
4848
max_duration = 2
4949
# This test runs unreasonably slow in CI for some reason. Allow 20 seconds extra.
5050
if in_ci():
51-
max_duration += 20
51+
max_duration += 25
5252
if use_pf_client: # PF client doesn't seem to parallelize, and takes about a second or 2 to start
5353
max_duration += 6.5
5454
assert diff < max_duration
@@ -76,7 +76,7 @@ def test_evaluate_parallelism(self, ten_queries_file, use_pf_client):
7676
# 2 batches at most, so it should take between 1 and 1.5 seconds.
7777
max_duration = 1.5
7878
if use_pf_client: # PF client doesn't seem to parallelize, and takes about a second to start.
79-
max_duration += 5
79+
max_duration += 7.5
8080
assert diff < max_duration
8181
row_result_df = pd.DataFrame(result["rows"])
8282
assert "outputs.slow.result" in row_result_df.columns

0 commit comments

Comments
 (0)