JSONL stream #39478
Open
JSONL stream #39478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
approved these changes
Feb 3, 2025
pvaneck
reviewed
Feb 3, 2025
kristapratico
requested review from
lmazuel,
annatisch and
johanste
as code owners
johanste
reviewed
Feb 5, 2025
johanste
reviewed
Feb 11, 2025
pvaneck
approved these changes
Feb 14, 2025
johanste
reviewed
Feb 14, 2025
| def json(self) -> Any: | ||
| """Parse the event data as JSON. | ||
|
|
||
| :return: The parsed JSON data. |
There was a problem hiding this comment.
I had to look up how json.load documents this (because "The parsed JSON data" is somewhat ambiguous and the return type hint isn't that helpful here :) and it says:
Deserialize fp to a Python object using the JSON-to-Python conversion table.
I think what we have here is more of an as_dict method.
But having that on the base EventType is probably wrong, because what if the event is not some form of structured data? E.g. SSE with just vanilla strings (and not json strings - which have to be quoted/escaped)
There was a problem hiding this comment.
Removed the EventTypes / assumptions of JSON being the only type of event data.
…t kw on Stream (more of an sse thing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38806
Implements the design described in https://gist.github.com/kristapratico/d330af39962ea05b10384b865e37b36f
PR adds types for JSONL streaming, SSE will come later.