JSONL stream #39478
JSONL stream #39478
Conversation
kristapratico
requested review from
lmazuel,
annatisch and
johanste
as code owners
| def json(self) -> Any: | ||
| """Parse the event data as JSON. | ||
|
|
||
| :return: The parsed JSON data. |
There was a problem hiding this comment.
I had to look up how json.load documents this (because "The parsed JSON data" is somewhat ambiguous and the return type hint isn't that helpful here :) and it says:
Deserialize fp to a Python object using the JSON-to-Python conversion table.
I think what we have here is more of an as_dict method.
But having that on the base EventType is probably wrong, because what if the event is not some form of structured data? E.g. SSE with just vanilla strings (and not json strings - which have to be quoted/escaped)
There was a problem hiding this comment.
Removed the EventTypes / assumptions of JSON being the only type of event data.
…t kw on Stream (more of an sse thing)
|
Hi @kristapratico. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Hi @kristapratico. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Part of #38806
Implements the design described in https://gist.github.com/kristapratico/d330af39962ea05b10384b865e37b36f
PR adds types for JSONL streaming, SSE will come later.