Skip to content

[Storage] [Named Keywords] [Blob] _blob_client.py and aio #40206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weirongw23-msft
Copy link
Member

@weirongw23-msft weirongw23-msft commented Mar 24, 2025

Edit: With the number of named keywords added, pylint is recognizing them as local variables. We have APIs that exceed the allowed amount of 25. For now, I've suppressed the error.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Mar 24, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft weirongw23-msft marked this pull request as ready for review April 9, 2025 19:55
Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! Will defer to Jacob for the final stamp of approval. :shipit:

@weirongw23-msft
Copy link
Member Author

/azp run python - pullrequest

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weirongw23-msft weirongw23-msft merged commit cce505a into Azure:feature/storage-blob-named-keywords Apr 23, 2025
23 checks passed
@weirongw23-msft weirongw23-msft deleted the weirongw23/blob-client-nk branch April 23, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants