-
Notifications
You must be signed in to change notification settings - Fork 3k
[Storage] [Named Keywords] [Blob] _blob_client.py
and aio
#40206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] [Named Keywords] [Blob] _blob_client.py
and aio
#40206
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
Azure Pipelines successfully started running 1 pipeline(s). |
… or default_value when default_value != None
/azp run python - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me! Will defer to Jacob for the final stamp of approval.
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client_helpers.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client_helpers.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client_helpers.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_blob_service_client.py
Show resolved
Hide resolved
/azp run python - pullrequest |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cce505a
into
Azure:feature/storage-blob-named-keywords
Edit: With the number of named keywords added,
pylint
is recognizing them as local variables. We have APIs that exceed the allowed amount of 25. For now, I've suppressed the error.