Skip to content

[Storage] [STG 98] Merge STG 98 Base Branch into Main #40381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 23, 2025

Conversation

weirongw23-msft
Copy link
Member

No description provided.

@weirongw23-msft weirongw23-msft marked this pull request as ready for review April 4, 2025 21:01
@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 21:01
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Apr 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 104 out of 105 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • sdk/storage/azure-storage-blob/assets.json: Language not supported
Comments suppressed due to low confidence (2)

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client_helpers.py:200

  • [nitpick] The newly introduced parameter 'source_token_intent' appears to serve a similar purpose to 'file_request_intent' in other operations. Consider unifying these parameter names for consistency and clarity across the SDK.
source_token_intent = kwargs.pop('source_token_intent', None)

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client_helpers.py:381

  • [nitpick] Ensure that there is adequate test coverage for the new 'source_token_intent' parameter flows (and its corresponding header 'x-ms-file-request-intent') in client helper methods.
options.update({k: v for k, v in kwargs.items() if v is not None})

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 4, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob
azure-storage-file-datalake
azure-storage-file-share
azure-storage-queue

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weirongw23-msft weirongw23-msft merged commit 8b9851a into main Apr 23, 2025
58 checks passed
@weirongw23-msft weirongw23-msft deleted the feature/storage-stg98 branch April 23, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants