Push updates from the latest typespec #40616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick863
requested review from
l0lawrence,
scbedd,
weshaggard,
benbp,
luigiw,
needuv,
paulshealy1,
singankit,
dargilco and
jhakulin
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the SDK based on the latest typespec, introducing new client implementations (both asynchronous and synchronous), updating configuration and type definitions, and refreshing ancillary package files.
- Added asynchronous and synchronous client implementations with updated request handling
- Introduced new configuration, types, version, and vendor files
- Updated package initialization and documentation for tests and licensing
Reviewed Changes
Copilot reviewed 147 out of 152 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/azure-ai-assistants/azure/ai/assistants/aio/_client.py | Introduces the async client with endpoint formatting and policy setup |
| sdk/ai/azure-ai-assistants/azure/ai/assistants/init.py | Sets up package export and versioning |
| sdk/ai/azure-ai-assistants/azure/ai/assistants/_client.py | Provides the synchronous client with similar functionalities |
| sdk/ai/azure-ai-assistants/azure/ai/assistants/_types.py | Defines type unions used across the SDK |
| Other files | Include configuration, vendor, patch, version, changelog, and packaging changes to support the updated typespec |
Files not reviewed (5)
- .vscode/cspell.json: Language not supported
- pylintrc: Language not supported
- sdk/ai/azure-ai-assistants/MANIFEST.in: Language not supported
- sdk/ai/azure-ai-assistants/apiview-properties.json: Language not supported
- sdk/ai/azure-ai-assistants/assets.json: Language not supported
Comments suppressed due to low confidence (1)
sdk/ai/azure-ai-assistants/azure/ai/assistants/_types.py:13
- [nitpick] The union type definition includes duplicate 'str' entries; removing the redundancy will improve clarity.
AssistantsApiResponseFormatOption = Union[
str,
str,
"_models.AssistantsApiResponseFormatMode",
"_models.AssistantsApiResponseFormat",
"_models.ResponseFormatJsonSchemaType",
]
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
dargilco
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines