[APIView] Parameterize CosmosPullRequestsRepository queries (#15748)

* Initial plan

* Use parameterized Cosmos queries for pull requests repository

Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>

* Bind optional Cosmos query params only when used

Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>

* Fix fluent QueryDefinition parameter assignment

Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tjprescott <5723682+tjprescott@users.noreply.github.com>

Author: Copilot

src/dotnet/APIView/APIViewWeb/Repositories/CosmosPullRequestsRepository.cs

@@ -6,7 +6,7 @@
 using System.Text;
 using System.Threading.Tasks;
 using APIViewWeb.Models;
-using APIViewWeb.Repositories;
+using APIViewWeb.Repositories;
 using Microsoft.Azure.Cosmos;
 using Microsoft.Extensions.Configuration;
 
@@ -25,12 +25,22 @@ public CosmosPullRequestsRepository(IConfiguration configuration, ICosmosReviewR
 
         public async Task<PullRequestModel> GetPullRequestAsync(int pullRequestNumber, string repoName, string packageName, string language = null)
         {
-            var queryBuilder  =  new StringBuilder($"SELECT * FROM PullRequests c WHERE c.PullRequestNumber = {pullRequestNumber} AND c.RepoName = '{repoName}' AND c.PackageName = '{packageName}' AND c.IsDeleted = false");
+            var queryBuilder = new StringBuilder("SELECT * FROM PullRequests c WHERE c.PullRequestNumber = @pullRequestNumber AND c.RepoName = @repoName AND c.PackageName = @packageName AND c.IsDeleted = false");
             if (language != null)
             {
-                queryBuilder.Append($" AND IS_DEFINED(c.Language) AND c.Language = '{language}'");
+                queryBuilder.Append(" AND IS_DEFINED(c.Language) AND c.Language = @language");
             }
-            var requests = await GetPullRequestFromQueryAsync(queryBuilder.ToString());
+
+            var queryDefinition = new QueryDefinition(queryBuilder.ToString())
+                .WithParameter("@pullRequestNumber", pullRequestNumber)
+                .WithParameter("@repoName", repoName)
+                .WithParameter("@packageName", packageName);
+            if (language != null)
+            {
+                queryDefinition = queryDefinition.WithParameter("@language", language);
+            }
+
+            var requests = await GetPullRequestFromQueryAsync(queryDefinition);
             return requests.Count > 0 ? requests[0] : null;
         }
 
@@ -41,30 +51,41 @@ public async Task UpsertPullRequestAsync(PullRequestModel pullRequestModel)
 
         public async Task<IEnumerable<PullRequestModel>> GetPullRequestsAsync(bool isOpen)
         {
-            var query = $"SELECT * FROM PullRequests c WHERE c.IsOpen = {(isOpen? "true": "false")} AND c.IsDeleted = false";
-            return await GetPullRequestFromQueryAsync(query);
-        }
-
+            var queryDefinition = new QueryDefinition("SELECT * FROM PullRequests c WHERE c.IsOpen = @isOpen AND c.IsDeleted = false")
+                .WithParameter("@isOpen", isOpen);
+            return await GetPullRequestFromQueryAsync(queryDefinition);
+        }
+
         public async Task<List<PullRequestModel>> GetPullRequestsAsync(int pullRequestNumber, string repoName)
         {
-            var query = $"SELECT * FROM PullRequests c WHERE c.PullRequestNumber = {pullRequestNumber} and c.RepoName = '{repoName}' AND c.IsDeleted = false";
-            return await GetPullRequestFromQueryAsync(query);
-        }
-
-        public async Task<IEnumerable<PullRequestModel>> GetPullRequestsAsync(string reviewId, string apiRevisionId = null) {
-            var query = $"SELECT * FROM PullRequests c WHERE c.ReviewId = '{reviewId}' AND c.IsDeleted = false";
-            if (!string.IsNullOrEmpty(apiRevisionId))
-            {
-                query += $" AND c.APIRevisionId = '{apiRevisionId}'";
-            }
-
-            return await GetPullRequestFromQueryAsync(query);
+            var queryDefinition = new QueryDefinition("SELECT * FROM PullRequests c WHERE c.PullRequestNumber = @pullRequestNumber AND c.RepoName = @repoName AND c.IsDeleted = false")
+                .WithParameter("@pullRequestNumber", pullRequestNumber)
+                .WithParameter("@repoName", repoName);
+            return await GetPullRequestFromQueryAsync(queryDefinition);
+        }
+
+        public async Task<IEnumerable<PullRequestModel>> GetPullRequestsAsync(string reviewId, string apiRevisionId = null)
+        {
+            var queryBuilder = new StringBuilder("SELECT * FROM PullRequests c WHERE c.ReviewId = @reviewId AND c.IsDeleted = false");
+            if (!string.IsNullOrEmpty(apiRevisionId))
+            {
+                queryBuilder.Append(" AND c.APIRevisionId = @apiRevisionId");
+            }
+
+            var queryDefinition = new QueryDefinition(queryBuilder.ToString())
+                .WithParameter("@reviewId", reviewId);
+            if (!string.IsNullOrEmpty(apiRevisionId))
+            {
+                queryDefinition = queryDefinition.WithParameter("@apiRevisionId", apiRevisionId);
+            }
+
+            return await GetPullRequestFromQueryAsync(queryDefinition);
         }
 
-        private async Task<List<PullRequestModel>> GetPullRequestFromQueryAsync(string query)
+        private async Task<List<PullRequestModel>> GetPullRequestFromQueryAsync(QueryDefinition queryDefinition)
         {
             var allRequests = new List<PullRequestModel>();
-            var itemQueryIterator = _pullRequestsContainer.GetItemQueryIterator<PullRequestModel>(query);
+            var itemQueryIterator = _pullRequestsContainer.GetItemQueryIterator<PullRequestModel>(queryDefinition);
             while (itemQueryIterator.HasMoreResults)
             {
                 var result = await itemQueryIterator.ReadNextAsync();
@@ -76,32 +97,32 @@ private async Task<List<PullRequestModel>> GetPullRequestFromQueryAsync(string q
             Dictionary<string, List<PullRequestModel>> kvp = new Dictionary<string, List<PullRequestModel>>();
             foreach (var pr in allRequests)
             {
-                if (!string.IsNullOrEmpty(pr.ReviewId))
+                if (!string.IsNullOrEmpty(pr.ReviewId))
+                {
+                    if (kvp.ContainsKey(pr.ReviewId))
+                    {
+                        kvp[pr.ReviewId].Add(pr);
+                    }
+                    else
+                    {
+                        kvp.Add(pr.ReviewId, new List<PullRequestModel> { pr });    
+                    }
+                }
+            }
+
+            if (kvp.Any())
+            {
+                var reviews = await _reviewsRepository.GetReviewsAsync(reviewIds: new List<string>(kvp.Keys), isClosed: false);
+                var reviewIds = reviews.Select(r => r.Id).ToList();
+
+                foreach (var kv in kvp)
                 {
-                    if (kvp.ContainsKey(pr.ReviewId))
-                    {
-                        kvp[pr.ReviewId].Add(pr);
-                    }
-                    else
-                    {
-                        kvp.Add(pr.ReviewId, new List<PullRequestModel> { pr });    
+                    if (reviewIds.Contains(kv.Key))
+                    {
+                        filtered.AddRange(kv.Value);
                     }
                 }
             }
-
-            if (kvp.Any())
-            {
-                var reviews = await _reviewsRepository.GetReviewsAsync(reviewIds: new List<string>(kvp.Keys), isClosed: false);
-                var reviewIds = reviews.Select(r => r.Id).ToList();
-
-                foreach (var kv in kvp)
-                {
-                    if (reviewIds.Contains(kv.Key))
-                    {
-                        filtered.AddRange(kv.Value);
-                    }
-                }
-            }
             return filtered;
         }
     }