Moving SAS token renewal part from MiscOpeationsHandler to RequestResponseLink so when connection is lost (#188)

and request-response link request is the first request on reconnection, SAS token is sent to service bus before attempting the request.

Author: yvgopal

azure-servicebus/src/main/java/com/microsoft/azure/servicebus/primitives/CoreMessageReceiver.java

@@ -1142,7 +1142,7 @@ private synchronized CompletableFuture<Void> ensureLinkIsOpen()
                                 TRACE_LOGGER.warn(operationTimedout.getMessage());
                                 linkReopenFutureThatCanBeCancelled.completeExceptionally(operationTimedout);
                             }
-	                    }	                    
+	                    }
 	                    , CoreMessageReceiver.LINK_REOPEN_TIMEOUT
 	                    , TimerType.OneTimeRun);
 	            this.cancelSASTokenRenewTimer();

azure-servicebus/src/main/java/com/microsoft/azure/servicebus/primitives/MessagingFactory.java

@@ -628,7 +628,7 @@ private CompletableFuture<Void> createCBSLinkAsync()
 	        String requestResponseLinkPath = RequestResponseLink.getCBSNodeLinkPath();
 	        TRACE_LOGGER.info("Creating CBS link to {}", requestResponseLinkPath);
 	        CompletableFuture<Void> crateAndAssignRequestResponseLink =
-	                        RequestResponseLink.createAsync(this, this.getClientId() + "-cbs", requestResponseLinkPath).handleAsync((cbsLink, ex) ->
+	                        RequestResponseLink.createAsync(this, this.getClientId() + "-cbs", requestResponseLinkPath, null).handleAsync((cbsLink, ex) ->
 	                        {
 	                            if(ex == null)
 	                            {

azure-servicebus/src/main/java/com/microsoft/azure/servicebus/primitives/MiscRequestResponseOperationHandler.java

@@ -1,9 +1,7 @@
 package com.microsoft.azure.servicebus.primitives;
 
-import java.time.ZonedDateTime;
 import java.util.*;
 import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.ScheduledFuture;
 
 import org.apache.qpid.proton.amqp.DescribedType;
 import org.apache.qpid.proton.message.Message;
@@ -18,63 +16,26 @@ public final class MiscRequestResponseOperationHandler extends ClientEntity
 
 	private final Object requestResonseLinkCreationLock = new Object();
 	private final String entityPath;
-	private final String sasTokenAudienceURI;
 	private final MessagingFactory underlyingFactory;
 	private RequestResponseLink requestResponseLink;
 	private CompletableFuture<Void> requestResponseLinkCreationFuture;
-	private ScheduledFuture<?> sasTokenRenewTimerFuture;
 
 	private MiscRequestResponseOperationHandler(MessagingFactory factory, String linkName, String entityPath)
 	{
 		super(linkName, factory);
 
 		this.underlyingFactory = factory;
 		this.entityPath = entityPath;
-		this.sasTokenAudienceURI = String.format(ClientConstants.SAS_TOKEN_AUDIENCE_FORMAT, factory.getHostName(), entityPath);
 	}	
 
 	public static CompletableFuture<MiscRequestResponseOperationHandler> create(MessagingFactory factory, String entityPath)
 	{
-	    CompletableFuture<MiscRequestResponseOperationHandler> creationFuture = new CompletableFuture<MiscRequestResponseOperationHandler>();
 	    MiscRequestResponseOperationHandler requestResponseOperationHandler = new MiscRequestResponseOperationHandler(factory, StringUtil.getShortRandomString(), entityPath);
-	    requestResponseOperationHandler.sendTokenAndSetRenewTimer(false).handleAsync((v, ex) -> {
-	        if(ex == null)
-	        {
-	            TRACE_LOGGER.info("Opened MiscRequestResponseOperationHandler");
-	            creationFuture.complete(requestResponseOperationHandler);
-	        }
-	        else
-	        {
-	            TRACE_LOGGER.error("Opening of MiscRequestResponseOperationHandler failed", ex);
-	            creationFuture.completeExceptionally(ExceptionUtil.extractAsyncCompletionCause(ex));
-	        }
-	        return null;
-	    });
-	    
-	    Timer.schedule(
-                new Runnable()
-                {
-                    public void run()
-                    {
-                        if (!creationFuture.isDone())
-                        {
-                            requestResponseOperationHandler.closeInternals();
-                            Exception operationTimedout = new TimeoutException(
-                                    String.format(Locale.US, "Open operation on CBSLink(%s) on Entity(%s) timed out at %s.", requestResponseOperationHandler.getClientId(), requestResponseOperationHandler.entityPath, ZonedDateTime.now().toString()));                            
-                            TRACE_LOGGER.warn(operationTimedout.getMessage());
-
-                            creationFuture.completeExceptionally(operationTimedout);
-                        }
-                    }
-                }
-                , factory.getOperationTimeout()
-                , TimerType.OneTimeRun);
-	    return creationFuture;		
+	    return CompletableFuture.completedFuture(requestResponseOperationHandler);		
 	}
 
 	private void closeInternals()
 	{
-	    this.cancelSASTokenRenewTimer();
         this.closeRequestResponseLink();
 	}
 
@@ -85,28 +46,6 @@ protected CompletableFuture<Void> onClose() {
 	    return CompletableFuture.completedFuture(null);
 	}
 
-	private CompletableFuture<Void> sendTokenAndSetRenewTimer(boolean retryOnFailure)
-    {
-        if(this.getIsClosingOrClosed())
-        {
-            return CompletableFuture.completedFuture(null);
-        }
-        else
-        {
-            CompletableFuture<ScheduledFuture<?>> sendTokenFuture = this.underlyingFactory.sendSecurityTokenAndSetRenewTimer(this.sasTokenAudienceURI, retryOnFailure, () -> this.sendTokenAndSetRenewTimer(true));
-            return sendTokenFuture.thenAccept((f) -> {this.sasTokenRenewTimerFuture = f; TRACE_LOGGER.debug("Set SAS Token renew timer");});
-        }
-    }
-    
-    private void cancelSASTokenRenewTimer()
-    {
-        if(this.sasTokenRenewTimerFuture != null && !this.sasTokenRenewTimerFuture.isDone())
-        {
-            TRACE_LOGGER.debug("Cancelling SAS Token renew timer");
-            this.sasTokenRenewTimerFuture.cancel(true);
-        }
-    }
-	
 	private CompletableFuture<Void> createRequestResponseLink()
 	{
 	    synchronized (this.requestResonseLinkCreationLock) {