fix(generator): qualify method receivers that collide with arm/storage import aliases (#5504)

* fix(generator): qualify method receivers that collide with arm/storage import aliases

A type whose name's last word is 'Storage' (e.g. FunctionsDeployment_Storage)
yielded a method receiver 'storage', shadowing the storage conversion-package
import alias in generated AssignProperties_To_* methods and breaking the build.
CreateReceiver already qualifies reserved words and short (<=3 char) names; also
qualify names that collide with the fixed conversion-package aliases (arm/storage).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Regenerate cognitiveservices UserOwnedStorage receivers

The generator fix qualifies method receivers that collide with the arm/storage
conversion-package import aliases. UserOwnedStorage's last word is "Storage", so
its receiver changes from "storage" to "ownedStorage". Regenerated repo-wide;
this is the only existing type affected.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Andrei Dorin Oprea <noreply@anthropic.com>

Author: andreidorin-oprea

v2/api/cognitiveservices/v1api20250601/account_types_gen.go

@@ -232,10 +232,13 @@ func (factory *identifierFactory) CreateReceiver(name string) string {
 
 	base := words[len(words)-1]
 
-	// Prefix with a qualifying term if one is available,
-	// AND either base is a reserved word, or it is too short (3 characters or less)
+	// Prefix with a qualifying term if one is available, AND the base is a reserved word, is too
+	// short (3 characters or less), or collides with a conversion-package alias (arm/storage) that
+	// the generated code imports - a bare receiver named after one of those would shadow the package.
 	if len(words) > 1 {
-		if _, found := factory.reservedWords[strings.ToLower(base)]; found || len(base) <= 3 {
+		lowerBase := strings.ToLower(base)
+		_, reserved := factory.reservedWords[lowerBase]
+		if reserved || len(base) <= 3 || forbiddenReceiverNames.Contains(lowerBase) {
 			base = words[len(words)-2] + base
 		}
 	}
@@ -296,6 +299,10 @@ func createForbiddenReceiverSuffixes() set.Set[string] {
 	return set.Make(status, spec)
 }
 
+// forbiddenReceiverNames are lowercase receiver names that would shadow a conversion-package import
+// (e.g. a type ending in "Storage" yields receiver "storage", clashing with the storage subpackage alias).
+var forbiddenReceiverNames = set.Make(strings.ToLower(ARMPackageName), strings.ToLower(StoragePackageName))
+
 func (factory *identifierFactory) CreateGroupName(group string) string {
 	return strings.TrimPrefix(strings.ToLower(group), "microsoft.")
 }

v2/tools/generator/internal/astmodel/identifier_factory.go

@@ -224,6 +224,9 @@ func Test_CreateReceiver_GivenTypeName_ReturnsExpectedResult(t *testing.T) {
 		{"DiskSku" + StatusSuffix, "diskSku"},
 		// Conflicts with reserved words need more detail
 		{"BlobRestoreRange" + StatusSuffix, "restoreRange"},
+		// Conflicts with conversion-package import aliases (arm/storage) need more detail
+		{"FunctionsDeployment_Storage", "deploymentStorage"},
+		{"FunctionsDeployment_Storage" + StatusSuffix, "deploymentStorage"},
 	}
 
 	factory := NewIdentifierFactory()