Ensure logger is destroyed before returning from mount command. (#2125)

Author: syeleti-msft

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 **Bug Fixes**
 - Fix panic while reading an archived blob using file-cache ([PR #2127](https://github.com/Azure/azure-storage-fuse/pull/2127)]
+- Ensure logger is properly deinitialized on mount failures ([PR #2125](https://github.com/Azure/azure-storage-fuse/pull/2125)]
 
 ## 2.5.2 (2026-01-19)
 **Features**

cmd/mount.go

@@ -440,6 +440,12 @@ var mountCmd = &cobra.Command{
 			return fmt.Errorf("failed to initialize logger [%s]", err.Error())
 		}
 
+		// It's best to destroy the logger before we return to the caller, as caller may abruptly exit on error and we
+		// might lose some logs in the channel which are not yet flushed to the file in case of not destroying the logger
+		defer func() {
+			_ = log.Destroy()
+		}()
+
 		if !disableVersionCheck {
 			err := VersionCheck()
 			if err != nil {

main.go

@@ -35,23 +35,11 @@ package main
 
 import (
 	"github.com/Azure/azure-storage-fuse/v2/cmd"
-	"github.com/Azure/azure-storage-fuse/v2/common/log"
 )
 
 //go:generate ./cmd/componentGenerator.sh $NAME
 //  To use go:generate run command   "NAME="component" go generate"
 
 func main() {
-	defer log.Destroy() // nolint:errcheck
-	// This recovers the panics only for the functions that run within this context. all the go-routine
-	// spawned by this function need to handle their panics separately if required. Also the FUSE callbacks
-	// wouldn't run in this context, so the panics originated from the callbacks can't get recovered here.
-	defer func() {
-		if panicErr := recover(); panicErr != nil {
-			log.Crit("PANIC: %v", panicErr)
-			panic(panicErr)
-		}
-	}()
-
 	_ = cmd.Execute()
 }