Use OIDC for live tests in FF (#9778)

* Switch to OIDC

* Remove if condition

* Set environment

Author: shenglol

.github/workflows/build.yml

@@ -615,8 +615,6 @@ jobs:
       - build-cli
       - can-run-live-tests
     if: needs.can-run-live-tests.outputs.access_verified == 'true'
-    env:
-      BICEP_SPN_PASSWORD_FF: ${{ secrets.BICEP_SPN_PASSWORD_FF }}
 
     steps:
       - uses: actions/checkout@v3
@@ -638,11 +636,11 @@ jobs:
 
       - name: Az CLI login
         uses: azure/login@v1
-        if: matrix.environment == 'prod'
         with:
-          client-id: ${{ secrets.LIVE_TEST_CLIENT_ID_PROD }}
-          tenant-id: ${{ secrets.LIVE_TEST_TENANT_ID_PROD }}
-          subscription-id: ${{ secrets.LIVE_TEST_SUBSCRIPTION_ID_PROD }}
+          environment: ${{ (matrix.environment == 'prod' && 'AzureCloud') || 'AzureUSGovernment' }}
+          client-id: ${{ (matrix.environment == 'prod' && secrets.LIVE_TEST_CLIENT_ID_PROD) || secrets.LIVE_TEST_CLIENT_ID_FF }}
+          tenant-id: ${{ (matrix.environment == 'prod' && secrets.LIVE_TEST_TENANT_ID_PROD) || secrets.LIVE_TEST_TENANT_ID_FF }}
+          subscription-id: ${{ (matrix.environment == 'prod' && secrets.LIVE_TEST_SUBSCRIPTION_ID_PROD) || secrets.LIVE_TEST_SUBSCRIPTION_ID_FF }}
 
       - name: Run Bicep Live E2E Tests (${{ matrix.environment }})
         run: npm ci && npm run test:live:${{ matrix.environment }}
@@ -665,8 +663,6 @@ jobs:
       - build-cli
       - can-run-live-tests
     if: needs.can-run-live-tests.outputs.access_verified == 'true'
-    env:
-      BICEP_SPN_PASSWORD_FF: ${{ secrets.BICEP_SPN_PASSWORD_FF }}
 
     steps:
       - uses: actions/checkout@v3
@@ -686,11 +682,11 @@ jobs:
 
       - name: Az CLI login
         uses: azure/login@v1
-        if: matrix.environment == 'prod'
         with:
-          client-id: ${{ secrets.LIVE_TEST_CLIENT_ID_PROD }}
-          tenant-id: ${{ secrets.LIVE_TEST_TENANT_ID_PROD }}
-          subscription-id: ${{ secrets.LIVE_TEST_SUBSCRIPTION_ID_PROD }}
+          environment: ${{ (matrix.environment == 'prod' && 'AzureCloud') || 'AzureUSGovernment' }}
+          client-id: ${{ (matrix.environment == 'prod' && secrets.LIVE_TEST_CLIENT_ID_PROD) || secrets.LIVE_TEST_CLIENT_ID_FF }}
+          tenant-id: ${{ (matrix.environment == 'prod' && secrets.LIVE_TEST_TENANT_ID_PROD) || secrets.LIVE_TEST_TENANT_ID_FF }}
+          subscription-id: ${{ (matrix.environment == 'prod' && secrets.LIVE_TEST_SUBSCRIPTION_ID_PROD) || secrets.LIVE_TEST_SUBSCRIPTION_ID_FF }}
 
       - name: Run Bicep Live E2E Tests (${{ matrix.environment }})
         run: npm ci && npm run test:live:${{ matrix.environment }}

src/Bicep.Cli.E2eTests/src/utils/liveTestEnvironments.ts

@@ -24,11 +24,7 @@ export const fairfax: LiveTestEnvironment = {
   registryUri: "biceptestff.azurecr.us",
   templateSpecSubscriptionId: "e21305d9-eef2-4990-8ed2-e2748236bee3",
   resourceSuffix: "ff",
-  environmentOverrides: {
-    AZURE_TENANT_ID: "63296244-ce2c-46d8-bc36-3e558792fbee",
-    AZURE_CLIENT_ID: "fbbb49e5-e59c-4fce-9d7b-13925a36ad7f",
-    AZURE_CLIENT_SECRET: process.env["BICEP_SPN_PASSWORD_FF"] ?? "",
-  },
+  environmentOverrides: {},
 };
 
 export function getEnvironment(): LiveTestEnvironment {