Skip to content

Commit eda735d

Browse files
mgamis-msftcn0151
andauthored
Together mode cherry picks to release/1.26.0-beta.1 (#5747)
* Fix issues where together mode stream keeps loading unitl views are c… (#5724) * Fix issues where together mode stream keeps loading unitl views are changed * Ensure the togethe mode view shows only in Teams call /Teams meeting * Revert back to beta in main (#5742) * Revert back to beta in main * Change files * Fixed pipeline failure * Revert tags * Upload api file --------- Co-authored-by: Chukwuebuka Nwankwo <[email protected]>
1 parent f7120d0 commit eda735d

File tree

10 files changed

+80
-134
lines changed

10 files changed

+80
-134
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"type": "prerelease",
3+
"area": "feature",
4+
"workstream": "together-mode",
5+
"comment": "Revert back to beta in main",
6+
"packageName": "@azure/communication-react",
7+
"dependentChangeType": "patch"
8+
}

common/config/babel/features.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,16 @@ module.exports = {
6868
// feature for tracking the callParticipantsLocator
6969
"call-participants-locator",
7070
// Feature for RTT
71-
"rtt"
71+
"rtt",
72+
// Feature for together mode
73+
"together-mode"
7274
],
7375
stable: [
7476
// Demo feature. Used in live-documentation of conditional compilation.
7577
// Do not use in production code.
7678
"stabilizedDemo",
7779
// Feature for breakout rooms
7880
"breakout-rooms",
79-
// Feature for together mode
80-
"together-mode"
81+
8182
]
8283
}

packages/calling-component-bindings/src/utils/videoGalleryUtils.ts

+5
Original file line numberDiff line numberDiff line change
@@ -262,3 +262,8 @@ export const memoizeTogetherModeStreams = memoizeOne((togetherModeStreams) => ({
262262
streamSize: togetherModeStreams?.mainVideoStream?.streamSize
263263
}
264264
}));
265+
266+
/** @private */
267+
export const memoizeTogetherModeSeatingPositions = memoizeOne(
268+
(togetherModeSeatingCoordinates) => togetherModeSeatingCoordinates
269+
);

packages/calling-component-bindings/src/videoGallerySelector.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ import {
3232
_dominantSpeakersWithFlatId,
3333
convertRemoteParticipantToVideoGalleryRemoteParticipant,
3434
memoizeLocalParticipant,
35-
/* @conditional-compile-remove(together-mode) */ memoizeTogetherModeStreams
35+
/* @conditional-compile-remove(together-mode) */ memoizeTogetherModeStreams,
36+
/* @conditional-compile-remove(together-mode) */ memoizeTogetherModeSeatingPositions
3637
} from './utils/videoGalleryUtils';
3738
import { memoizeSpotlightedParticipantIds } from './utils/videoGalleryUtils';
3839
import { getLocalParticipantRaisedHand } from './baseSelectors';
@@ -165,7 +166,7 @@ export const videoGallerySelector: VideoGallerySelector = createSelector(
165166
/* @conditional-compile-remove(together-mode) */
166167
togetherModeStreams: memoizeTogetherModeStreams(togetherModeCallFeature?.streams),
167168
/* @conditional-compile-remove(together-mode) */
168-
togetherModeSeatingCoordinates: togetherModeCallFeature?.seatingPositions,
169+
togetherModeSeatingCoordinates: memoizeTogetherModeSeatingPositions(togetherModeCallFeature?.seatingPositions),
169170
/* @conditional-compile-remove(together-mode) */
170171
isTogetherModeActive: togetherModeCallFeature?.isActive,
171172
/* @conditional-compile-remove(together-mode) */

packages/communication-react/review/beta/communication-react.api.md

+8
Original file line numberDiff line numberDiff line change
@@ -438,12 +438,14 @@ export interface CallAdapterCallOperations {
438438
addParticipant(participant: CommunicationUserIdentifier): Promise<void>;
439439
allowUnsupportedBrowserVersion(): void;
440440
createStreamView(remoteUserId?: string, options?: VideoStreamOptions): Promise<void | CreateVideoStreamViewResult>;
441+
// @beta
441442
createTogetherModeStreamView(options?: TogetherModeStreamOptions): Promise<void | TogetherModeStreamViewResult>;
442443
disposeLocalVideoStreamView(): Promise<void>;
443444
disposeRemoteVideoStreamView(remoteUserId: string): Promise<void>;
444445
disposeScreenShareStreamView(remoteUserId: string): Promise<void>;
445446
// @deprecated
446447
disposeStreamView(remoteUserId?: string, options?: VideoStreamOptions): Promise<void>;
448+
// @beta
447449
disposeTogetherModeStreamView(): Promise<void>;
448450
forbidAudio(userIds: string[]): Promise<void>;
449451
forbidOthersAudio(): Promise<void>;
@@ -469,12 +471,14 @@ export interface CallAdapterCallOperations {
469471
sendRealTimeText: (text: string, isFinalized: boolean) => Promise<void>;
470472
setCaptionLanguage(language: string): Promise<void>;
471473
setSpokenLanguage(language: string): Promise<void>;
474+
// @beta
472475
setTogetherModeSceneSize(width: number, height: number): void;
473476
startCamera(options?: VideoStreamOptions): Promise<void>;
474477
startCaptions(options?: StartCaptionsAdapterOptions): Promise<void>;
475478
startNoiseSuppressionEffect(): Promise<void>;
476479
startScreenShare(): Promise<void>;
477480
startSpotlight(userIds?: string[]): Promise<void>;
481+
// @beta
478482
startTogetherMode(): Promise<void>;
479483
startVideoBackgroundEffect(videoBackgroundEffect: VideoBackgroundEffect): Promise<void>;
480484
stopAllSpotlight(): Promise<void>;
@@ -1270,6 +1274,7 @@ export interface CallWithChatAdapterManagement {
12701274
allowUnsupportedBrowserVersion(): void;
12711275
askDevicePermission(constrain: PermissionConstraints): Promise<DeviceAccess>;
12721276
createStreamView(remoteUserId?: string, options?: VideoStreamOptions): Promise<void | CreateVideoStreamViewResult>;
1277+
// @beta
12731278
createTogetherModeStreamView(options?: TogetherModeStreamOptions): Promise<void | TogetherModeStreamViewResult>;
12741279
// @beta
12751280
deleteImage(imageId: string): Promise<void>;
@@ -1278,6 +1283,7 @@ export interface CallWithChatAdapterManagement {
12781283
disposeRemoteVideoStreamView(remoteUserId: string): Promise<void>;
12791284
disposeScreenShareStreamView(remoteUserId: string): Promise<void>;
12801285
disposeStreamView(remoteUserId?: string, options?: VideoStreamOptions): Promise<void>;
1286+
// @beta
12811287
disposeTogetherModeStreamView(): Promise<void>;
12821288
// (undocumented)
12831289
downloadResourceToCache(resourceDetails: ResourceDetails): Promise<void>;
@@ -1321,6 +1327,7 @@ export interface CallWithChatAdapterManagement {
13211327
setMicrophone(sourceInfo: AudioDeviceInfo): Promise<void>;
13221328
setSpeaker(sourceInfo: AudioDeviceInfo): Promise<void>;
13231329
setSpokenLanguage(language: string): Promise<void>;
1330+
// @beta
13241331
setTogetherModeSceneSize(width: number, height: number): void;
13251332
startCall(participants: string[], options?: StartCallOptions): Call | undefined;
13261333
startCall(participants: (MicrosoftTeamsAppIdentifier | PhoneNumberIdentifier | CommunicationUserIdentifier | MicrosoftTeamsUserIdentifier | UnknownIdentifier)[], options?: StartCallOptions): Call | undefined;
@@ -1329,6 +1336,7 @@ export interface CallWithChatAdapterManagement {
13291336
startNoiseSuppressionEffect(): Promise<void>;
13301337
startScreenShare(): Promise<void>;
13311338
startSpotlight(userIds?: string[]): Promise<void>;
1339+
// @beta
13321340
startTogetherMode(): Promise<void>;
13331341
startVideoBackgroundEffect(videoBackgroundEffect: VideoBackgroundEffect): Promise<void>;
13341342
stopAllSpotlight(): Promise<void>;

0 commit comments

Comments
 (0)