Skip to content

Commit 76d49d8

Browse files
nishthaAhujaaNishtha Ahuja
nishthaAhujaa
and
Nishtha Ahuja
authored
Added emulator checks in settings pane fields (#2041)
* added emulator checks * created macro * conditions as const --------- Co-authored-by: Nishtha Ahuja <[email protected]>
1 parent 7893b89 commit 76d49d8

File tree

1 file changed

+70
-60
lines changed

1 file changed

+70
-60
lines changed

‎src/Explorer/Panes/SettingsPane/SettingsPane.tsx

+70-60
Original file line numberDiff line numberDiff line change
@@ -174,15 +174,26 @@ export const SettingsPane: FunctionComponent<{ explorer: Explorer }> = ({
174174
const styles = useStyles();
175175

176176
const explorerVersion = configContext.gitSha;
177+
const isEmulator = configContext.platform === Platform.Emulator;
177178
const shouldShowQueryPageOptions = userContext.apiType === "SQL";
178-
const shouldShowGraphAutoVizOption = userContext.apiType === "Gremlin";
179-
const shouldShowCrossPartitionOption = userContext.apiType !== "Gremlin";
180-
const shouldShowParallelismOption = userContext.apiType !== "Gremlin";
181-
const shouldShowPriorityLevelOption = PriorityBasedExecutionUtils.isFeatureEnabled();
179+
const showRetrySettings =
180+
(userContext.apiType === "SQL" || userContext.apiType === "Tables" || userContext.apiType === "Gremlin") &&
181+
!isEmulator;
182+
const shouldShowGraphAutoVizOption = userContext.apiType === "Gremlin" && !isEmulator;
183+
const shouldShowCrossPartitionOption = userContext.apiType !== "Gremlin" && !isEmulator;
184+
const shouldShowParallelismOption = userContext.apiType !== "Gremlin" && !isEmulator;
185+
const showEnableEntraIdRbac =
186+
userContext.apiType === "SQL" &&
187+
userContext.authType === AuthType.AAD &&
188+
configContext.platform !== Platform.Fabric &&
189+
!isEmulator;
190+
const shouldShowPriorityLevelOption = PriorityBasedExecutionUtils.isFeatureEnabled() && !isEmulator;
182191
const shouldShowCopilotSampleDBOption =
183192
userContext.apiType === "SQL" &&
184193
useQueryCopilot.getState().copilotEnabled &&
185-
useDatabases.getState().sampleDataResourceTokenCollection;
194+
useDatabases.getState().sampleDataResourceTokenCollection &&
195+
!isEmulator;
196+
186197
const handlerOnSubmit = async () => {
187198
setIsExecuting(true);
188199

@@ -541,39 +552,37 @@ export const SettingsPane: FunctionComponent<{ explorer: Explorer }> = ({
541552
</AccordionPanel>
542553
</AccordionItem>
543554
)}
544-
{userContext.apiType === "SQL" &&
545-
userContext.authType === AuthType.AAD &&
546-
configContext.platform !== Platform.Fabric && (
547-
<AccordionItem value="2">
548-
<AccordionHeader>
549-
<div className={styles.header}>Enable Entra ID RBAC</div>
550-
</AccordionHeader>
551-
<AccordionPanel>
552-
<div className={styles.settingsSectionContainer}>
553-
<div className={styles.settingsSectionDescription}>
554-
Choose Automatic to enable Entra ID RBAC automatically. True/False to force enable/disable Entra
555-
ID RBAC.
556-
<a
557-
href="https://learn.microsoft.com/en-us/azure/cosmos-db/how-to-setup-rbac#use-data-explorer"
558-
target="_blank"
559-
rel="noopener noreferrer"
560-
>
561-
{" "}
562-
Learn more{" "}
563-
</a>
564-
</div>
565-
<ChoiceGroup
566-
ariaLabelledBy="enableDataPlaneRBACOptions"
567-
options={dataPlaneRBACOptionsList}
568-
styles={choiceButtonStyles}
569-
selectedKey={enableDataPlaneRBACOption}
570-
onChange={handleOnDataPlaneRBACOptionChange}
571-
/>
555+
{showEnableEntraIdRbac && (
556+
<AccordionItem value="2">
557+
<AccordionHeader>
558+
<div className={styles.header}>Enable Entra ID RBAC</div>
559+
</AccordionHeader>
560+
<AccordionPanel>
561+
<div className={styles.settingsSectionContainer}>
562+
<div className={styles.settingsSectionDescription}>
563+
Choose Automatic to enable Entra ID RBAC automatically. True/False to force enable/disable Entra ID
564+
RBAC.
565+
<a
566+
href="https://learn.microsoft.com/en-us/azure/cosmos-db/how-to-setup-rbac#use-data-explorer"
567+
target="_blank"
568+
rel="noopener noreferrer"
569+
>
570+
{" "}
571+
Learn more{" "}
572+
</a>
572573
</div>
573-
</AccordionPanel>
574-
</AccordionItem>
575-
)}
576-
{userContext.apiType === "SQL" && (
574+
<ChoiceGroup
575+
ariaLabelledBy="enableDataPlaneRBACOptions"
576+
options={dataPlaneRBACOptionsList}
577+
styles={choiceButtonStyles}
578+
selectedKey={enableDataPlaneRBACOption}
579+
onChange={handleOnDataPlaneRBACOptionChange}
580+
/>
581+
</div>
582+
</AccordionPanel>
583+
</AccordionItem>
584+
)}
585+
{userContext.apiType === "SQL" && !isEmulator && (
577586
<>
578587
<AccordionItem value="3">
579588
<AccordionHeader>
@@ -671,7 +680,7 @@ export const SettingsPane: FunctionComponent<{ explorer: Explorer }> = ({
671680
</AccordionItem>
672681
</>
673682
)}
674-
{(userContext.apiType === "SQL" || userContext.apiType === "Tables" || userContext.apiType === "Gremlin") && (
683+
{showRetrySettings && (
675684
<AccordionItem value="6">
676685
<AccordionHeader>
677686
<div className={styles.header}>Retry Settings</div>
@@ -744,29 +753,30 @@ export const SettingsPane: FunctionComponent<{ explorer: Explorer }> = ({
744753
</AccordionPanel>
745754
</AccordionItem>
746755
)}
747-
748-
<AccordionItem value="7">
749-
<AccordionHeader>
750-
<div className={styles.header}>Enable container pagination</div>
751-
</AccordionHeader>
752-
<AccordionPanel>
753-
<div className={styles.settingsSectionContainer}>
754-
<div className={styles.settingsSectionDescription}>
755-
Load 50 containers at a time. Currently, containers are not pulled in alphanumeric order.
756+
{!isEmulator && (
757+
<AccordionItem value="7">
758+
<AccordionHeader>
759+
<div className={styles.header}>Enable container pagination</div>
760+
</AccordionHeader>
761+
<AccordionPanel>
762+
<div className={styles.settingsSectionContainer}>
763+
<div className={styles.settingsSectionDescription}>
764+
Load 50 containers at a time. Currently, containers are not pulled in alphanumeric order.
765+
</div>
766+
<Checkbox
767+
styles={{
768+
label: { padding: 0 },
769+
}}
770+
className="padding"
771+
ariaLabel="Enable container pagination"
772+
checked={containerPaginationEnabled}
773+
onChange={() => setContainerPaginationEnabled(!containerPaginationEnabled)}
774+
label="Enable container pagination"
775+
/>
756776
</div>
757-
<Checkbox
758-
styles={{
759-
label: { padding: 0 },
760-
}}
761-
className="padding"
762-
ariaLabel="Enable container pagination"
763-
checked={containerPaginationEnabled}
764-
onChange={() => setContainerPaginationEnabled(!containerPaginationEnabled)}
765-
label="Enable container pagination"
766-
/>
767-
</div>
768-
</AccordionPanel>
769-
</AccordionItem>
777+
</AccordionPanel>
778+
</AccordionItem>
779+
)}
770780
{shouldShowCrossPartitionOption && (
771781
<AccordionItem value="8">
772782
<AccordionHeader>

0 commit comments

Comments
 (0)