Skip to content

Commit a17837e

Browse files
authored
fix: disable override controllers for debugging purposes (#784)
1 parent f72a65a commit a17837e

File tree

3 files changed

+4
-22
lines changed

3 files changed

+4
-22
lines changed

cmd/hubagent/workload/setup.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import (
2828
"go.goms.io/fleet/pkg/controllers/clusterresourceplacementwatcher"
2929
"go.goms.io/fleet/pkg/controllers/clusterschedulingpolicysnapshot"
3030
"go.goms.io/fleet/pkg/controllers/memberclusterplacement"
31-
"go.goms.io/fleet/pkg/controllers/overrider"
3231
"go.goms.io/fleet/pkg/controllers/resourcechange"
3332
"go.goms.io/fleet/pkg/controllers/rollout"
3433
"go.goms.io/fleet/pkg/controllers/workgenerator"
@@ -287,27 +286,6 @@ func SetupControllers(ctx context.Context, wg *sync.WaitGroup, mgr ctrl.Manager,
287286
klog.ErrorS(err, "Unable to set up memberCluster watcher for scheduler")
288287
return err
289288
}
290-
291-
// setup override related controllers
292-
klog.Info("Setting up the clusterResourceOverride controller")
293-
if err := (&overrider.ClusterResourceReconciler{
294-
Reconciler: overrider.Reconciler{
295-
Client: mgr.GetClient(),
296-
},
297-
}).SetupWithManager(mgr); err != nil {
298-
klog.ErrorS(err, "Unable to set up clusterResourceOverride controller")
299-
return err
300-
}
301-
302-
klog.Info("Setting up the resourceOverride controller")
303-
if err := (&overrider.ResourceReconciler{
304-
Reconciler: overrider.Reconciler{
305-
Client: mgr.GetClient(),
306-
},
307-
}).SetupWithManager(mgr); err != nil {
308-
klog.ErrorS(err, "Unable to set up resourceOverride controller")
309-
return err
310-
}
311289
}
312290

313291
// Set up a runner that starts all the custom controllers we created above

test/e2e/placement_cro_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ var _ = Describe("creating clusterResourceOverride (selecting all clusters) to o
2222
croName := fmt.Sprintf(croNameTemplate, GinkgoParallelProcess())
2323

2424
BeforeAll(func() {
25+
Skip("CRO controller is not enabled yet")
26+
2527
By("creating work resources")
2628
createWorkResources()
2729

test/e2e/placement_ro_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ var _ = Describe("creating resourceOverride (selecting all clusters) to override
2424
roNamespace := fmt.Sprintf(workNamespaceNameTemplate, GinkgoParallelProcess())
2525

2626
BeforeAll(func() {
27+
Skip("RO controller is not enabled yet")
28+
2729
By("creating work resources")
2830
createWorkResources()
2931

0 commit comments

Comments
 (0)