Suspicious commented-out code

[quasilyte]

While doing an audit, I've found pieces of code like:

func (p *state) packFloat(o option, v interface{}) error {
	fmt.Println("pack: float")
	// return p.pack(o, v)
	return nil
}


func (p *state) packString(o option, v interface{}) error {
	fmt.Println("pack: string")
	// return p.pack(o, v)
	return nil
}

It looks like commented-out code should be uncommented while fmt.Println statement is to be removed.
Since I'm not familiar with the project or what the packer is, opening an issue instead of sending you a PR.

Another suspicious place:

func (p *state) packInt(o option, v interface{}) error {
	// fmt.Printf("packInt (%t) => %T\n", o.typ == optUint, v)
	if v, ok := v.(Packer); ok {
		return v.Pack(p)
	}
	// return p.pack(o, v)
	return nil
}

[quasilyte]

In the std/debug package there is also something scary:

func dbgGetUserValue(state *lua.State) int {
	fmt.Println("debug.getuservalue")
	state.Debug(true)
	// if state.TypeAt(1) != lua.UserDataType {
	// 	state.Push(nil)
	// } else {
	// 	state.GetUserValue(1)
	// }
	return 1
}

Commented-out code should be either:

• Removed
• Uncommented if it's needed
• Or at least add a comment why it's commented-out and how it can be fixed

[quasilyte]

Found another thing:

golua/std/base/base.go

Lines 184 to 188 in 4ee7f28

	// error message is on top of the stack
	state.Push(nil)
	state.Push(err.Error())
	// state.Insert(-2) // put before error message
	return 2 // return nil plus error message

It's unclear for me whether // state.Insert(-2) // put before error message is needed or not.
But maybe maintainers know better. :)