Merge pull request #17 from yugangw-msft/equal

fix a bug in model class equality

Author: lmazuel

msrest/serialization.py

@@ -93,7 +93,7 @@ def __init__(self, *args, **kwargs):
     def __eq__(self, other):
         """Compare objects by comparing all attributes."""
         if isinstance(other, self.__class__):
-            return self.__class__.__dict__ == other.__class__.__dict__
+            return self.__dict__ == other.__dict__
         return False
 
     def __ne__(self, other):

test/unittest_serialization.py

@@ -716,7 +716,6 @@ def __init__(self, name=None, likes_mice=None, dislikes = None, color=None):
 
         self.s.dependencies = old_dependencies
 
-
 class TestRuntimeDeserialized(unittest.TestCase):
 
     class TestObj(Model):
@@ -1311,6 +1310,24 @@ def __init__(self, name=None, likes_dog_food=None):
         self.assertIsInstance(animal, Dog)
         self.assertTrue(animal.likes_dog_food)
 
+class TestModelInstanceEquality(unittest.TestCase):
+
+    def test_model_instance_equality(self):
+
+        class Animal(Model):
+
+            _attribute_map = {
+                "name":{"key":"Name", "type":"str"},
+            }
+
+            def __init__(self, name=None):
+                self.name = name
+
+        animal1 = Animal('a1')
+        animal2 = Animal('a2')
+        animal3 = Animal('a1')
+        self.assertTrue(animal1!=animal2)
+        self.assertTrue(animal1==animal3)
 
 if __name__ == '__main__':
     unittest.main()