move deprecated variables into deprecated_variables.tf file

Author: lonegunmanb

deprecated_variables.tf

@@ -0,0 +1,29 @@
+variable "agents_taints" {
+  type        = list(string)
+  default     = null
+  description = "DEPRECATED, (Optional) A list of the taints added to new nodes during node pool create and scale. Changing this forces a new resource to be created."
+}
+
+variable "api_server_subnet_id" {
+  type        = string
+  default     = null
+  description = "DEPRECATED, (Optional) The ID of the Subnet where the API server endpoint is delegated to."
+}
+
+variable "rbac_aad_client_app_id" {
+  type        = string
+  default     = null
+  description = "DEPRECATED, The Client ID of an Azure Active Directory Application."
+}
+
+variable "rbac_aad_server_app_id" {
+  type        = string
+  default     = null
+  description = "DEPRECATED, The Server ID of an Azure Active Directory Application."
+}
+
+variable "rbac_aad_server_app_secret" {
+  type        = string
+  default     = null
+  description = "DEPRECATED, The Server Secret of an Azure Active Directory Application."
+}

v4/main_override.tf

@@ -295,6 +295,8 @@ resource "azurerm_kubernetes_cluster" "main" {
       kubernetes_version,
       # we might have a random suffix in cluster's name so we have to ignore it here, but we've traced user supplied cluster name by `null_resource.kubernetes_cluster_name_keeper` so when the name is changed we'll recreate this resource.
       name,
-    api_server_access_profile, network_profile[0].load_balancer_profile[0].outbound_ip_address_ids, network_profile[0].load_balancer_profile[0].outbound_ip_prefix_ids]
+      network_profile[0].load_balancer_profile[0].outbound_ip_address_ids,
+      network_profile[0].load_balancer_profile[0].outbound_ip_prefix_ids,
+    ]
   }
 }

variables.tf

@@ -210,12 +210,6 @@ variable "agents_tags" {
   description = "(Optional) A mapping of tags to assign to the Node Pool."
 }
 
-variable "agents_taints" {
-  type        = list(string)
-  default     = null
-  description = "(Optional) A list of the taints added to new nodes during node pool create and scale. Changing this forces a new resource to be created."
-}
-
 variable "agents_type" {
   type        = string
   default     = "VirtualMachineScaleSets"
@@ -228,12 +222,6 @@ variable "api_server_authorized_ip_ranges" {
   description = "(Optional) The IP ranges to allow for incoming traffic to the server nodes."
 }
 
-variable "api_server_subnet_id" {
-  type        = string
-  default     = null
-  description = "(Optional) The ID of the Subnet where the API server endpoint is delegated to."
-}
-
 variable "attached_acr_id_map" {
   type        = map(string)
   default     = {}
@@ -794,7 +782,7 @@ variable "maintenance_window" {
     allowed = optional(list(object({
       day   = string
       hours = set(number)
-      })), [
+    })), [
     ]),
     not_allowed = optional(list(object({
       end   = string
@@ -1285,31 +1273,13 @@ variable "rbac_aad_azure_rbac_enabled" {
   description = "(Optional) Is Role Based Access Control based on Azure AD enabled?"
 }
 
-variable "rbac_aad_client_app_id" {
-  type        = string
-  default     = null
-  description = "The Client ID of an Azure Active Directory Application."
-}
-
 variable "rbac_aad_managed" {
   type        = bool
   default     = false
   description = "Is the Azure Active Directory integration Managed, meaning that Azure will create/manage the Service Principal used for integration."
   nullable    = false
 }
 
-variable "rbac_aad_server_app_id" {
-  type        = string
-  default     = null
-  description = "The Server ID of an Azure Active Directory Application."
-}
-
-variable "rbac_aad_server_app_secret" {
-  type        = string
-  default     = null
-  description = "The Server Secret of an Azure Active Directory Application."
-}
-
 variable "rbac_aad_tenant_id" {
   type        = string
   default     = null