Skip to content

Commit 3c38f50

Browse files
author
github-actions[bot]
committed
fix: allow 'None' and 'System' values for private_dns_zone_id validation
- Update lifecycle precondition to accept Azure's special string values - Fixes issue where private_dns_zone_id = 'None' was incorrectly rejected - Maintains existing validation for actual DNS zone resource IDs - Resolves #689 Tested with both 'None' and 'System' values using examples/startup
1 parent be56dbf commit 3c38f50

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -664,8 +664,8 @@ resource "azurerm_kubernetes_cluster" "main" {
664664
error_message = "A user assigned identity or a service principal must be used when using a custom private dns zone"
665665
}
666666
precondition {
667-
condition = var.private_dns_zone_id == null ? true : (anytrue([for r in local.valid_private_dns_zone_regexs : try(regex(r, local.private_dns_zone_name) == local.private_dns_zone_name, false)]))
668-
error_message = "According to the [document](https://learn.microsoft.com/en-us/azure/aks/private-clusters?tabs=azure-portal#configure-a-private-dns-zone), the private DNS zone must be in one of the following format: `privatelink.<region>.azmk8s.io`, `<subzone>.privatelink.<region>.azmk8s.io`, `private.<region>.azmk8s.io`, `<subzone>.private.<region>.azmk8s.io`"
667+
condition = (var.private_dns_zone_id == null || var.private_dns_zone_id == "None" || var.private_dns_zone_id == "System") ? true : (anytrue([for r in local.valid_private_dns_zone_regexs : try(regex(r, local.private_dns_zone_name) == local.private_dns_zone_name, false)]))
668+
error_message = "The private_dns_zone_id must be either null, \"None\", \"System\", or a valid private DNS zone resource ID. Valid DNS zone formats are: `privatelink.<region>.azmk8s.io`, `<subzone>.privatelink.<region>.azmk8s.io`, `private.<region>.azmk8s.io`, `<subzone>.private.<region>.azmk8s.io`"
669669
}
670670
}
671671
}

0 commit comments

Comments
 (0)