add var.create_monitor_data_collection_rule so users could skip creation of dcr resources in this module

Author: lonegunmanb

log_analytics.tf

@@ -69,7 +69,7 @@ locals {
 }
 
 resource "azurerm_monitor_data_collection_rule" "dcr" {
-  count = (local.create_analytics_workspace && var.oms_agent_enabled) ? 1 : 0
+  count = local.create_analytics_workspace && var.oms_agent_enabled && var.create_monitor_data_collection_rule ? 1 : 0
 
   location            = local.dcr_location
   name                = "MSCI-${local.dcr_location}-${azurerm_kubernetes_cluster.main.name}"
@@ -115,7 +115,7 @@ resource "azurerm_monitor_data_collection_rule" "dcr" {
 }
 
 resource "azurerm_monitor_data_collection_rule_association" "dcra" {
-  count = (local.create_analytics_workspace && var.oms_agent_enabled) ? 1 : 0
+  count = local.create_analytics_workspace && var.oms_agent_enabled && var.create_monitor_data_collection_rule ? 1 : 0
 
   target_resource_id      = azurerm_kubernetes_cluster.main.id
   data_collection_rule_id = azurerm_monitor_data_collection_rule.dcr[0].id

main.tf

@@ -693,13 +693,13 @@ resource "time_sleep" "interval_before_cluster_update" {
 }
 
 resource "azapi_update_resource" "aks_cluster_post_create" {
-  type = "Microsoft.ContainerService/managedClusters@2024-02-01"
+  resource_id = azurerm_kubernetes_cluster.main.id
+  type        = "Microsoft.ContainerService/managedClusters@2024-02-01"
   body = {
     properties = {
       kubernetesVersion = var.kubernetes_version
     }
   }
-  resource_id = azurerm_kubernetes_cluster.main.id
 
   depends_on = [
     time_sleep.interval_before_cluster_update,
@@ -722,15 +722,15 @@ resource "null_resource" "http_proxy_config_no_proxy_keeper" {
 resource "azapi_update_resource" "aks_cluster_http_proxy_config_no_proxy" {
   count = can(var.http_proxy_config.no_proxy[0]) ? 1 : 0
 
-  type = "Microsoft.ContainerService/managedClusters@2024-02-01"
+  resource_id = azurerm_kubernetes_cluster.main.id
+  type        = "Microsoft.ContainerService/managedClusters@2024-02-01"
   body = {
     properties = {
       httpProxyConfig = {
         noProxy = var.http_proxy_config.no_proxy
       }
     }
   }
-  resource_id = azurerm_kubernetes_cluster.main.id
 
   depends_on = [azapi_update_resource.aks_cluster_post_create]
 

variables.tf

@@ -436,6 +436,13 @@ variable "cost_analysis_enabled" {
   description = "(Optional) Enable Cost Analysis."
 }
 
+variable "create_monitor_data_collection_rule" {
+  type        = bool
+  default     = true
+  description = "Create monitor data collection rule resource for the AKS cluster. Defaults to `true`."
+  nullable    = false
+}
+
 variable "create_role_assignment_network_contributor" {
   type        = bool
   default     = false