Not getting credit for my contributions to the repo

[taustgen]

Is there an existing issue for this?

• I have searched the existing issues

Greenfield/Brownfield provisioning

greenfield

Terraform Version

n/a

Module Version

n/a

AzureRM Provider Version

n/a

Affected Resource(s)/Data Source(s)

n/a

Terraform Configuration Files

n/a

tfvars variables values

n/a

Debug Output/Panic Output

n/a

Expected Behaviour

Hey @lonegunmanb, whats the deal with my contributions appearing under you on the release? Taking credit for my PRs is kinda shady. I hadnt noticed at the time, I just saw they were merged. Rather than asking for changes, you changed my base branch to one of yours, merged it and then told me it was in.

Best of luck with this module in the future

#654
#659

https://github.com/Azure/terraform-azurerm-aks/releases/tag/10.0.0

Actual Behaviour

I'm listed in new contributors on the release for my improvements.

Steps to Reproduce

No response

Important Factoids

No response

References

No response

[lonegunmanb]

@taustgen So sorry for this, please accept my apology and I have corrected the release note:https://github.com/Azure/terraform-azurerm-aks/releases/tag/10.0.0

Please allow me to explain. We have to authenticate with Azure to run e2e tests, we used to use self-hosted runners with managed identity, but as this document described, using self-hosted GitHub Actions runner is not safe, so we switched to GitHub OIDC. OIDC generated token cannot be used with pull requests come from fork repo, so we have to merge your pr into a release branch, and create a new pull request there to kick off the tests.

Due to other security harden policy, we cannot update main branch directly, so our original CHANGELOG auto update action cannot work anymore, we have to generate release notes in GitHub's release page, using GitHub provided "Generate release notes", but it seems like this feature missed your commits somehow.

Again, while I know this is no excuse, I hope you can accept my sincere apology, I did not mean to do that, and thanks a lot for your contribution.

[paulblum00]

Hi, I'm also affected by this with my PR

• fix wrongly reported sensitivity error with client_secret #629
• Add nonsensitive around for_each argument #631
• Second change in https://github.com/Azure/terraform-azurerm-aks/releases/tag/10.0.0

[lonegunmanb]

@paulblum00 Sorry for this, I've updated the release note.

[lonegunmanb]

I'm closing this issue but please feel free to leave comments here if anyone who found naming missing in the release notes, I'll be happy to amend and sorry for that.