Skip to content

Commit c47eeb6

Browse files
jchancellor-msjchancellor-ms
authored
Typo and whitespace fixes (#160)
* whitespace issues * adding editor config * removed v3 default example * added zones for example pub ip * temporary disable on pubip example * app gw example fix * version and readonly change * ignore changes on vm agent platform updates
1 parent a2d77d9 commit c47eeb6

42 files changed

Lines changed: 238 additions & 797 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.editorconfig‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
root = true
2+
3+
[*]
4+
charset = utf-8
5+
end_of_line = lf
6+
insert_final_newline = true
7+
indent_style = space
8+
indent_size = 2
9+
trim_trailing_whitespace = true

‎README.md‎

Lines changed: 27 additions & 27 deletions
Large diffs are not rendered by default.

‎examples/basic_windows_w_additional_disks_public_ip/README.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module "regions" {
5454
5555
locals {
5656
#deployment_region = module.regions.regions[random_integer.region_index.result].name
57-
deployment_region = "canadacentral" #temporarily pinning on single region
57+
deployment_region = "canadacentral" #temporarily pinning on single region
5858
tags = {
5959
scenario = "Default"
6060
}
@@ -97,7 +97,7 @@ module "vm_sku" {
9797
9898
module "natgateway" {
9999
source = "Azure/avm-res-network-natgateway/azurerm"
100-
version = "0.2.0"
100+
version = "0.2.1"
101101
102102
name = module.naming.nat_gateway.name_unique
103103
enable_telemetry = true
@@ -113,7 +113,7 @@ module "natgateway" {
113113
114114
module "vnet" {
115115
source = "Azure/avm-res-network-virtualnetwork/azurerm"
116-
version = "=0.7.1"
116+
version = "=0.8.1"
117117
118118
resource_group_name = azurerm_resource_group.this_rg.name
119119
address_space = ["10.0.0.0/16"]
@@ -223,8 +223,8 @@ module "testvm" {
223223
ip_configuration_1 = {
224224
name = "${module.naming.network_interface.name_unique}-ipconfig1"
225225
private_ip_subnet_resource_id = module.vnet.subnets["vm_subnet_1"].resource_id
226-
create_public_ip_address = true
227-
public_ip_address_name = module.naming.public_ip.name_unique
226+
#create_public_ip_address = true
227+
#public_ip_address_name = module.naming.public_ip.name_unique
228228
}
229229
}
230230
}
@@ -327,7 +327,7 @@ Version: ~> 0.4
327327

328328
Source: Azure/avm-res-network-natgateway/azurerm
329329

330-
Version: 0.2.0
330+
Version: 0.2.1
331331

332332
### <a name="module_regions"></a> [regions](#module\_regions)
333333

@@ -351,7 +351,7 @@ Version: 0.3.0
351351

352352
Source: Azure/avm-res-network-virtualnetwork/azurerm
353353

354-
Version: =0.7.1
354+
Version: =0.8.1
355355

356356
<!-- markdownlint-disable-next-line MD041 -->
357357
## Data Collection

‎examples/basic_windows_w_additional_disks_public_ip/main.tf‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module "regions" {
3535

3636
locals {
3737
#deployment_region = module.regions.regions[random_integer.region_index.result].name
38-
deployment_region = "canadacentral" #temporarily pinning on single region
38+
deployment_region = "canadacentral" #temporarily pinning on single region
3939
tags = {
4040
scenario = "Default"
4141
}
@@ -78,7 +78,7 @@ module "vm_sku" {
7878

7979
module "natgateway" {
8080
source = "Azure/avm-res-network-natgateway/azurerm"
81-
version = "0.2.0"
81+
version = "0.2.1"
8282

8383
name = module.naming.nat_gateway.name_unique
8484
enable_telemetry = true
@@ -94,7 +94,7 @@ module "natgateway" {
9494

9595
module "vnet" {
9696
source = "Azure/avm-res-network-virtualnetwork/azurerm"
97-
version = "=0.7.1"
97+
version = "=0.8.1"
9898

9999
resource_group_name = azurerm_resource_group.this_rg.name
100100
address_space = ["10.0.0.0/16"]
@@ -204,8 +204,8 @@ module "testvm" {
204204
ip_configuration_1 = {
205205
name = "${module.naming.network_interface.name_unique}-ipconfig1"
206206
private_ip_subnet_resource_id = module.vnet.subnets["vm_subnet_1"].resource_id
207-
create_public_ip_address = true
208-
public_ip_address_name = module.naming.public_ip.name_unique
207+
#create_public_ip_address = true
208+
#public_ip_address_name = module.naming.public_ip.name_unique
209209
}
210210
}
211211
}

‎examples/basic_windows_w_azure_monitor_agent/README.md‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ module "regions" {
5656
5757
locals {
5858
#deployment_region = module.regions.regions[random_integer.region_index.result].name
59-
deployment_region = "canadacentral" #temporarily pinning on single region
59+
deployment_region = "canadacentral" #temporarily pinning on single region
6060
tags = {
6161
scenario = "Default"
6262
}
@@ -99,7 +99,7 @@ module "vm_sku" {
9999
100100
module "natgateway" {
101101
source = "Azure/avm-res-network-natgateway/azurerm"
102-
version = "0.2.0"
102+
version = "0.2.1"
103103
104104
name = module.naming.nat_gateway.name_unique
105105
enable_telemetry = true
@@ -115,7 +115,7 @@ module "natgateway" {
115115
116116
module "vnet" {
117117
source = "Azure/avm-res-network-virtualnetwork/azurerm"
118-
version = "=0.7.1"
118+
version = "=0.8.1"
119119
120120
resource_group_name = azurerm_resource_group.this_rg.name
121121
address_space = ["10.0.0.0/16"]
@@ -296,7 +296,7 @@ module "testvm" {
296296
{
297297
"EncryptionOperation": "EnableEncryption",
298298
"KeyVaultURL": "${data.azurerm_key_vault.this.vault_uri}",
299-
"KeyVaultResourceId": "${module.avm_res_keyvault_vault.resource_id}",
299+
"KeyVaultResourceId": "${module.avm_res_keyvault_vault.resource_id}",
300300
"KeyEncryptionAlgorithm": "RSA-OAEP",
301301
"VolumeType": "All"
302302
}
@@ -520,7 +520,7 @@ Version: ~> 0.4
520520

521521
Source: Azure/avm-res-network-natgateway/azurerm
522522

523-
Version: 0.2.0
523+
Version: 0.2.1
524524

525525
### <a name="module_regions"></a> [regions](#module\_regions)
526526

@@ -544,7 +544,7 @@ Version: 0.3.0
544544

545545
Source: Azure/avm-res-network-virtualnetwork/azurerm
546546

547-
Version: =0.7.1
547+
Version: =0.8.1
548548

549549
<!-- markdownlint-disable-next-line MD041 -->
550550
## Data Collection

‎examples/basic_windows_w_azure_monitor_agent/main.tf‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module "regions" {
3535

3636
locals {
3737
#deployment_region = module.regions.regions[random_integer.region_index.result].name
38-
deployment_region = "canadacentral" #temporarily pinning on single region
38+
deployment_region = "canadacentral" #temporarily pinning on single region
3939
tags = {
4040
scenario = "Default"
4141
}
@@ -78,7 +78,7 @@ module "vm_sku" {
7878

7979
module "natgateway" {
8080
source = "Azure/avm-res-network-natgateway/azurerm"
81-
version = "0.2.0"
81+
version = "0.2.1"
8282

8383
name = module.naming.nat_gateway.name_unique
8484
enable_telemetry = true
@@ -94,7 +94,7 @@ module "natgateway" {
9494

9595
module "vnet" {
9696
source = "Azure/avm-res-network-virtualnetwork/azurerm"
97-
version = "=0.7.1"
97+
version = "=0.8.1"
9898

9999
resource_group_name = azurerm_resource_group.this_rg.name
100100
address_space = ["10.0.0.0/16"]
@@ -275,7 +275,7 @@ module "testvm" {
275275
{
276276
"EncryptionOperation": "EnableEncryption",
277277
"KeyVaultURL": "${data.azurerm_key_vault.this.vault_uri}",
278-
"KeyVaultResourceId": "${module.avm_res_keyvault_vault.resource_id}",
278+
"KeyVaultResourceId": "${module.avm_res_keyvault_vault.resource_id}",
279279
"KeyEncryptionAlgorithm": "RSA-OAEP",
280280
"VolumeType": "All"
281281
}

‎examples/basic_windows_w_encryption_at_host/README.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ module "regions" {
5757
5858
locals {
5959
#deployment_region = module.regions.regions[random_integer.region_index.result].name
60-
deployment_region = "canadacentral" #temporarily pinning on single region
60+
deployment_region = "canadacentral" #temporarily pinning on single region
6161
tags = {
6262
scenario = "Default"
6363
}
@@ -100,7 +100,7 @@ module "vm_sku" {
100100
101101
module "natgateway" {
102102
source = "Azure/avm-res-network-natgateway/azurerm"
103-
version = "0.2.0"
103+
version = "0.2.1"
104104
105105
name = module.naming.nat_gateway.name_unique
106106
enable_telemetry = true
@@ -116,7 +116,7 @@ module "natgateway" {
116116
117117
module "vnet" {
118118
source = "Azure/avm-res-network-virtualnetwork/azurerm"
119-
version = "=0.7.1"
119+
version = "=0.8.1"
120120
121121
resource_group_name = azurerm_resource_group.this_rg.name
122122
address_space = ["10.0.0.0/16"]
@@ -375,7 +375,7 @@ Version: ~> 0.4
375375

376376
Source: Azure/avm-res-network-natgateway/azurerm
377377

378-
Version: 0.2.0
378+
Version: 0.2.1
379379

380380
### <a name="module_regions"></a> [regions](#module\_regions)
381381

@@ -399,7 +399,7 @@ Version: 0.3.0
399399

400400
Source: Azure/avm-res-network-virtualnetwork/azurerm
401401

402-
Version: =0.7.1
402+
Version: =0.8.1
403403

404404
<!-- markdownlint-disable-next-line MD041 -->
405405
## Data Collection

‎examples/basic_windows_w_encryption_at_host/main.tf‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module "regions" {
3535

3636
locals {
3737
#deployment_region = module.regions.regions[random_integer.region_index.result].name
38-
deployment_region = "canadacentral" #temporarily pinning on single region
38+
deployment_region = "canadacentral" #temporarily pinning on single region
3939
tags = {
4040
scenario = "Default"
4141
}
@@ -78,7 +78,7 @@ module "vm_sku" {
7878

7979
module "natgateway" {
8080
source = "Azure/avm-res-network-natgateway/azurerm"
81-
version = "0.2.0"
81+
version = "0.2.1"
8282

8383
name = module.naming.nat_gateway.name_unique
8484
enable_telemetry = true
@@ -94,7 +94,7 @@ module "natgateway" {
9494

9595
module "vnet" {
9696
source = "Azure/avm-res-network-virtualnetwork/azurerm"
97-
version = "=0.7.1"
97+
version = "=0.8.1"
9898

9999
resource_group_name = azurerm_resource_group.this_rg.name
100100
address_space = ["10.0.0.0/16"]

‎examples/basic_windows_w_load_balancing/README.md‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ module "regions" {
5757
5858
locals {
5959
#deployment_region = module.regions.regions[random_integer.region_index.result].name
60-
deployment_region = "canadacentral" #temporarily pinning on single region
60+
deployment_region = "canadacentral" #temporarily pinning on single region
6161
tags = {
6262
scenario = "Default"
6363
}
@@ -100,7 +100,7 @@ module "vm_sku" {
100100
101101
module "natgateway" {
102102
source = "Azure/avm-res-network-natgateway/azurerm"
103-
version = "0.2.0"
103+
version = "0.2.1"
104104
105105
name = module.naming.nat_gateway.name_unique
106106
enable_telemetry = true
@@ -116,7 +116,7 @@ module "natgateway" {
116116
117117
module "vnet" {
118118
source = "Azure/avm-res-network-virtualnetwork/azurerm"
119-
version = "=0.7.1"
119+
version = "=0.8.1"
120120
121121
resource_group_name = azurerm_resource_group.this_rg.name
122122
address_space = ["10.0.0.0/16"]
@@ -232,12 +232,14 @@ resource "azurerm_public_ip" "app_gw_pip" {
232232
name = local.app_gw_public_ip_name
233233
resource_group_name = azurerm_resource_group.this_rg.name
234234
sku = "Standard"
235+
zones = ["1", "2", "3"]
235236
}
236237
237238
resource "azurerm_application_gateway" "network" {
238239
location = azurerm_resource_group.this_rg.location
239240
name = "example-appgateway"
240241
resource_group_name = azurerm_resource_group.this_rg.name
242+
zones = ["1", "2", "3"]
241243
242244
backend_address_pool {
243245
name = local.backend_address_pool_name
@@ -498,7 +500,7 @@ Version: ~> 0.4
498500

499501
Source: Azure/avm-res-network-natgateway/azurerm
500502

501-
Version: 0.2.0
503+
Version: 0.2.1
502504

503505
### <a name="module_regions"></a> [regions](#module\_regions)
504506

@@ -528,7 +530,7 @@ Version: 0.3.0
528530

529531
Source: Azure/avm-res-network-virtualnetwork/azurerm
530532

531-
Version: =0.7.1
533+
Version: =0.8.1
532534

533535
<!-- markdownlint-disable-next-line MD041 -->
534536
## Data Collection

‎examples/basic_windows_w_load_balancing/main.tf‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module "regions" {
3535

3636
locals {
3737
#deployment_region = module.regions.regions[random_integer.region_index.result].name
38-
deployment_region = "canadacentral" #temporarily pinning on single region
38+
deployment_region = "canadacentral" #temporarily pinning on single region
3939
tags = {
4040
scenario = "Default"
4141
}
@@ -78,7 +78,7 @@ module "vm_sku" {
7878

7979
module "natgateway" {
8080
source = "Azure/avm-res-network-natgateway/azurerm"
81-
version = "0.2.0"
81+
version = "0.2.1"
8282

8383
name = module.naming.nat_gateway.name_unique
8484
enable_telemetry = true
@@ -94,7 +94,7 @@ module "natgateway" {
9494

9595
module "vnet" {
9696
source = "Azure/avm-res-network-virtualnetwork/azurerm"
97-
version = "=0.7.1"
97+
version = "=0.8.1"
9898

9999
resource_group_name = azurerm_resource_group.this_rg.name
100100
address_space = ["10.0.0.0/16"]
@@ -210,12 +210,14 @@ resource "azurerm_public_ip" "app_gw_pip" {
210210
name = local.app_gw_public_ip_name
211211
resource_group_name = azurerm_resource_group.this_rg.name
212212
sku = "Standard"
213+
zones = ["1", "2", "3"]
213214
}
214215

215216
resource "azurerm_application_gateway" "network" {
216217
location = azurerm_resource_group.this_rg.location
217218
name = "example-appgateway"
218219
resource_group_name = azurerm_resource_group.this_rg.name
220+
zones = ["1", "2", "3"]
219221

220222
backend_address_pool {
221223
name = local.backend_address_pool_name

0 commit comments

Comments
 (0)