Description
Check for previous/existing GitHub issues
- I have checked for previous/existing GitHub issues
Description
Hi,
Whilst it could be argued that I should have just read the module docs properly (which would be fair!) I'd like to suggest having the default value for generate_admin_password_or_ssh_key be false rather than true.
I lost a load of time today trying to work out why my passwords weren't working despite clearly providing them via var.admin_password. At first, I thought the vendor image (it is a network appliance) was just ignoring, so went down a rabbit hole.
It is only when I later poked about state that I realised my var.admin_password value had been ignored because of the default value of generate_admin_password_or_ssh_key being true. However, due to the special characters, it caused issues with my particular network appliance and I couldn't login, even when I knew what the password was.
I'd like to propose generate_admin_password_or_ssh_key being false as a more sensible default, as I'm sure I'm not going to be the only one who got tripped up by this unexpected default, though I can appreciate the default in order to try and be helpful.
Thanks in advance for your consideration, and I appreciate the contributions you've made to the module!