[AVM Question/Feedback]: Make generate_admin_password_or_ssh_key default to false or disable when password/key provided

[natilik-mikeguy]

Check for previous/existing GitHub issues

• I have checked for previous/existing GitHub issues

Description

Hi,

Whilst it could be argued that I should have just read the module docs properly (which would be fair!) I'd like to suggest having the default value for generate_admin_password_or_ssh_key be false rather than true.

I lost a load of time today trying to work out why my passwords weren't working despite clearly providing them via var.admin_password. At first, I thought the vendor image (it is a network appliance) was just ignoring, so went down a rabbit hole.

It is only when I later poked about state that I realised my var.admin_password value had been ignored because of the default value of generate_admin_password_or_ssh_key being true. However, due to the special characters, it caused issues with my particular network appliance and I couldn't login, even when I knew what the password was.

I'd like to propose generate_admin_password_or_ssh_key being false as a more sensible default, as I'm sure I'm not going to be the only one who got tripped up by this unexpected default, though I can appreciate the default in order to try and be helpful.

Thanks in advance for your consideration, and I appreciate the contributions you've made to the module!

[jchancellor-ms]

@natilik-mikeguy - great feedback. The auto-generation was intended to make things simple and may be causing more headaches than simplification. Let me look at options to see if this can be made more intuitive while continuing to support existing deployments.

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[microsoft-github-policy-service]

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-terraform) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

• To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
• To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

[microsoft-github-policy-service]

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-terraform) immediate attention as it hasn't been responded to within 6 business days. **

Tip

• To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
• Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.