fix: remove serverFarmId casing replace that causes perpetual plan diff (#132)

The resource_id output was using replace() to convert Azure's returned
'serverfarms' (lowercase) to 'serverFarms' (uppercase F). This caused
perpetual drift for azapi consumers: Azure normalizes the ID back to
lowercase on read, so every plan showed a diff.

Remove the replace() and output the ID as Azure returns it. This was
originally added for issue #129 (azurerm provider ID parsing), but that
is a provider limitation that consumers can handle with their own
replace() if needed.

Closes #131

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: ethanjenkins1

avm

@@ -173,6 +173,15 @@ if [ -f "avm.config.json" ]; then
   done
 fi
 
+# Forward AVM_BARE_* environment variables to the container with the prefix stripped
+while IFS='=' read -r bareKey bareValue; do
+  [ -z "$bareKey" ] && continue
+  strippedKey="${bareKey#AVM_BARE_}"
+  export "$strippedKey"="$bareValue"
+  LOCAL_ENVIRONMENT_VARIABLES="${LOCAL_ENVIRONMENT_VARIABLES}-e $strippedKey "
+  echo "Forwarding AVM bare variable to container as: $strippedKey"
+done < <(env | grep '^AVM_BARE_' || true)
+
 # Check if we are running in a container
 # If we are then just run make directly
 if [ -z "${AVM_IN_CONTAINER}" ]; then
@@ -199,7 +208,7 @@ if [ -z "${AVM_IN_CONTAINER}" ]; then
     -e TF_IN_AUTOMATION=1 \
     ${LOCAL_ENVIRONMENT_VARIABLES} \
     --env-file <(env | grep '^TF_VAR_') \
-    --env-file <(env | grep '^AVM_') \
+    --env-file <(env | grep '^AVM_' | grep -v '^AVM_BARE_') \
     "${CONTAINER_IMAGE}" \
     make \
     TUI="${TUI}" \

avm.ps1

@@ -150,11 +150,18 @@ if (-not $env:AVM_IN_CONTAINER) {
     $dockerArgs += @("-e", "$($_.Name)=$($_.Value)")
   }
 
-  # Add AVM_ environment variables
-  Get-ChildItem env: | Where-Object { $_.Name -like "AVM_*" } | ForEach-Object {
+  # Add AVM_ environment variables (excluding AVM_BARE_* which are forwarded with the prefix stripped)
+  Get-ChildItem env: | Where-Object { $_.Name -like "AVM_*" -and $_.Name -notlike "AVM_BARE_*" } | ForEach-Object {
     $dockerArgs += @("-e", "$($_.Name)=$($_.Value)")
   }
 
+  # Forward AVM_BARE_* environment variables to the container with the prefix stripped
+  Get-ChildItem env: | Where-Object { $_.Name -like "AVM_BARE_*" } | ForEach-Object {
+    $strippedName = $_.Name -replace '^AVM_BARE_', ''
+    $dockerArgs += @("-e", "$strippedName=$($_.Value)")
+    Write-Host "Forwarding AVM bare variable to container as: $strippedName"
+  }
+
   # Add local environment variables from avm.config.json
   if (Test-Path "avm.config.json") {
     $jsonContent = Get-Content "avm.config.json" -Raw | ConvertFrom-Json -AsHashtable

outputs.tf

@@ -5,5 +5,5 @@ output "name" {
 
 output "resource_id" {
   description = "Resource id of the app service plan"
-  value       = replace(azapi_resource.this.id, "Microsoft.Web/serverfarms/", "Microsoft.Web/serverFarms/")
+  value       = azapi_resource.this.id
 }