feat: add configurable wait before zip deploy for SCM settings propagation (#265)

* feat: add configurable wait before zip deploy for SCM settings propagation

Add a time_sleep resource between app settings/connection strings configuration
and zip deploy to allow the SCM site to pick up settings like
SCM_DO_BUILD_DURING_DEPLOYMENT before the deploy triggers.

- Add hashicorp/time provider
- Add zip_deploy_wait_duration variable (default 60s)
- Add time_sleep.wait_for_app_settings resource before zip deploy

* docs: update README for zip_deploy_wait_duration

Author: jaredfholgate

README.md

@@ -19,6 +19,8 @@ The following requirements are needed by this module:
 
 - <a name="requirement_random"></a> [random](#requirement\_random) (>= 3.5.0, < 4.0.0)
 
+- <a name="requirement_time"></a> [time](#requirement\_time) (>= 0.9.0, < 1.0.0)
+
 ## Resources
 
 The following resources are used by this module:
@@ -34,6 +36,7 @@ The following resources are used by this module:
 - [azapi_resource_action.active_slot](https://registry.terraform.io/providers/Azure/azapi/latest/docs/resources/resource_action) (resource)
 - [modtm_telemetry.telemetry](https://registry.terraform.io/providers/azure/modtm/latest/docs/resources/telemetry) (resource)
 - [random_uuid.telemetry](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/uuid) (resource)
+- [time_sleep.wait_for_app_settings](https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/sleep) (resource)
 - [azapi_client_config.telemetry](https://registry.terraform.io/providers/Azure/azapi/latest/docs/data-sources/client_config) (data source)
 - [modtm_module_source.telemetry](https://registry.terraform.io/providers/azure/modtm/latest/docs/data-sources/module_source) (data source)
 
@@ -2257,6 +2260,14 @@ Type: `string`
 
 Default: `null`
 
+### <a name="input_zip_deploy_wait_duration"></a> [zip\_deploy\_wait\_duration](#input\_zip\_deploy\_wait\_duration)
+
+Description: The duration to wait after applying app settings and connection strings before triggering zip deploy. This allows the SCM site to pick up settings like `SCM_DO_BUILD_DURING_DEPLOYMENT` before the deploy starts.
+
+Type: `string`
+
+Default: `"60s"`
+
 ## Outputs
 
 The following outputs are exported:

main.deploy.tf

@@ -1,3 +1,14 @@
+resource "time_sleep" "wait_for_app_settings" {
+  for_each = var.zip_deploy_file != null ? { "default" = {} } : {}
+
+  create_duration = var.zip_deploy_wait_duration
+
+  depends_on = [
+    module.config_appsettings,
+    module.config_connectionstrings,
+  ]
+}
+
 module "extensions_zipdeploy" {
   source   = "./modules/extensions_zipdeploy"
   for_each = var.zip_deploy_file != null ? { "default" = {} } : {}
@@ -6,7 +17,6 @@ module "extensions_zipdeploy" {
   zip_deploy_file = var.zip_deploy_file
 
   depends_on = [
-    module.config_appsettings,
-    module.config_connectionstrings,
+    time_sleep.wait_for_app_settings,
   ]
 }

terraform.tf

@@ -14,5 +14,9 @@ terraform {
       source  = "hashicorp/random"
       version = ">= 3.5.0, < 4.0.0"
     }
+    time = {
+      source  = "hashicorp/time"
+      version = ">= 0.9.0, < 1.0.0"
+    }
   }
 }

variables.tf

@@ -2082,3 +2082,9 @@ variable "zip_deploy_file" {
   default     = null
   description = "The path to the zip file to deploy to the App Service."
 }
+
+variable "zip_deploy_wait_duration" {
+  type        = string
+  default     = "60s"
+  description = "The duration to wait after applying app settings and connection strings before triggering zip deploy. This allows the SCM site to pick up settings like `SCM_DO_BUILD_DURING_DEPLOYMENT` before the deploy starts."
+}