Uptake compiler internals (#2357)

Main changes:
- Ast reference updated to `@typespec/compiler/ast`
- Stop using `getOption`
- Keep tgcc workaround as using internal api

Author: timotheeguerin

.chronus/changes/uptake-compiler-internals-2025-2-11-19-7-49.md

@@ -0,0 +1,11 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: fix
+packages:
+  - "@azure-tools/typespec-autorest"
+  - "@azure-tools/typespec-azure-core"
+  - "@azure-tools/typespec-azure-resource-manager"
+  - "@azure-tools/typespec-client-generator-core"
+---
+
+Cleanup use of typespec compiler internal apis.

core

@@ -44,7 +44,6 @@ import {
   Scalar,
   StringLiteral,
   StringTemplate,
-  SyntaxKind,
   Type,
   TypeNameOptions,
   Union,
@@ -101,6 +100,7 @@ import {
   resolvePath,
   serializeValueAsJson,
 } from "@typespec/compiler";
+import { SyntaxKind } from "@typespec/compiler/ast";
 import { $ } from "@typespec/compiler/experimental/typekit";
 import { TwoLevelMap } from "@typespec/compiler/utils";
 import {

packages/typespec-autorest/src/openapi.ts

@@ -1,11 +1,11 @@
 import {
-  SyntaxKind,
   createRule,
   getDiscriminator,
   getTypeName,
   isTemplateInstance,
   paramMessage,
 } from "@typespec/compiler";
+import { SyntaxKind } from "@typespec/compiler/ast";
 
 export const compositionOverInheritanceRule = createRule({
   name: "composition-over-inheritance",

packages/typespec-azure-core/src/rules/composition-over-inheritance.ts

@@ -14,11 +14,11 @@ import {
   Operation,
   paramMessage,
   Scalar,
-  SyntaxKind,
   Type,
   Union,
   UnionVariant,
 } from "@typespec/compiler";
+import { SyntaxKind } from "@typespec/compiler/ast";
 
 export const friendlyNameRule = createRule({
   name: "friendly-name",

packages/typespec-azure-core/src/rules/friendly-name.ts

@@ -1,16 +1,18 @@
 import {
   CodeFix,
   Enum,
-  EnumMemberNode,
-  EnumSpreadMemberNode,
-  Node,
-  SyntaxKind,
-  TypeSpecScriptNode,
   createRule,
   getPositionBeforeTrivia,
   getSourceLocation,
   paramMessage,
 } from "@typespec/compiler";
+import {
+  type EnumMemberNode,
+  type EnumSpreadMemberNode,
+  type Node,
+  SyntaxKind,
+  type TypeSpecScriptNode,
+} from "@typespec/compiler/ast";
 import { getVersionsForEnum } from "@typespec/versioning";
 export const noEnumRule = createRule({
   name: "no-enum",

packages/typespec-azure-core/src/rules/no-enum.ts

@@ -2,10 +2,10 @@ import {
   Interface,
   Operation,
   Program,
-  TypeReferenceNode,
   createRule,
   getNamespaceFullName,
 } from "@typespec/compiler";
+import { TypeReferenceNode } from "@typespec/compiler/ast";
 import { isExcludedCoreType } from "./utils.js";
 
 function getTypeReferenceNamespace(program: Program, ref: TypeReferenceNode): string {

packages/typespec-azure-core/src/rules/prevent-rest-library.ts

@@ -1,4 +1,5 @@
-import { Model, SyntaxKind, createRule, getDiscriminator, paramMessage } from "@typespec/compiler";
+import { Model, createRule, getDiscriminator, paramMessage } from "@typespec/compiler";
+import { SyntaxKind } from "@typespec/compiler/ast";
 
 export const spreadDiscriminatedModelRule = createRule({
   name: "spread-discriminated-model",

packages/typespec-azure-core/src/rules/spread-discriminated-model.ts

@@ -11,10 +11,10 @@ import {
   Program,
   Scalar,
   SourceLocation,
-  SyntaxKind,
   Union,
   UnionVariant,
 } from "@typespec/compiler";
+import { SyntaxKind } from "@typespec/compiler/ast";
 
 type DeclarableType =
   | Namespace

packages/typespec-azure-core/src/rules/utils.ts

@@ -19,7 +19,7 @@ export const namespace = "Azure.ResourceManager.CommonTypes.Private";
 export const ArmCommonTypesDefaultVersion = "v3";
 
 function getArmTypesPath(program: Program): string {
-  return program.getOption("arm-types-path") || "{arm-types-dir}";
+  return "{arm-types-dir}";
 }
 
 function storeCommonTypeRecord(

packages/typespec-azure-resource-manager/src/commontypes.private.decorators.ts

@@ -3,12 +3,11 @@ import {
   ModelProperty,
   Operation,
   Program,
-  SyntaxKind,
   createRule,
   paramMessage,
 } from "@typespec/compiler";
+import { SyntaxKind } from "@typespec/compiler/ast";
 import { HttpVerb, getOperationVerb } from "@typespec/http";
-
 import {
   getNamespaceName,
   getSourceModel,

packages/typespec-azure-resource-manager/src/rules/core-operations.ts

@@ -9,8 +9,8 @@ import {
   Namespace,
   Operation,
   Program,
-  SyntaxKind,
 } from "@typespec/compiler";
+import { SyntaxKind } from "@typespec/compiler/ast";
 import { getResourceOperation } from "@typespec/rest";
 import { ArmResourceOperation } from "../operations.js";
 import { ArmResourceDetails, getArmResourceKind } from "../resource.js";

packages/typespec-azure-resource-manager/src/rules/utils.ts

@@ -1,20 +1,16 @@
 import {
-  AugmentDecoratorStatementNode,
   DecoratorContext,
-  DecoratorExpressionNode,
   DecoratorFunction,
   Enum,
   EnumMember,
   Interface,
   Model,
   ModelProperty,
   Namespace,
-  Node,
   Operation,
   Program,
   RekeyableMap,
   Scalar,
-  SyntaxKind,
   Type,
   Union,
   getDiscriminator,
@@ -24,6 +20,7 @@ import {
   isTemplateDeclaration,
   isTemplateDeclarationOrInstance,
 } from "@typespec/compiler";
+import { SyntaxKind, type Node } from "@typespec/compiler/ast";
 import {
   AccessDecorator,
   AlternateTypeDecorator,
@@ -789,19 +786,20 @@ export const $clientName: ClientNameDecorator = (
   // workaround for current lack of functionality in compiler
   // https://github.com/microsoft/typespec/issues/2717
   if (entity.kind === "Model" || entity.kind === "Operation") {
-    if ((context.decoratorTarget as Node).kind === SyntaxKind.AugmentDecoratorStatement) {
+    const target = context.decoratorTarget as Node;
+    if (target.kind === SyntaxKind.AugmentDecoratorStatement) {
       if (
-        ignoreDiagnostics(
-          context.program.checker.resolveTypeReference(
-            (context.decoratorTarget as AugmentDecoratorStatementNode).targetType,
-          ),
+        (
+          ignoreDiagnostics(
+            (context.program.checker as any).resolveTypeReference(target.targetType),
+          ) as any
         )?.node !== entity.node
       ) {
         return;
       }
     }
-    if ((context.decoratorTarget as Node).kind === SyntaxKind.DecoratorExpression) {
-      if ((context.decoratorTarget as DecoratorExpressionNode).parent !== entity.node) {
+    if (target.kind === SyntaxKind.DecoratorExpression) {
+      if (target.parent !== entity.node) {
         return;
       }
     }

packages/typespec-client-generator-core/src/decorators.ts

@@ -1,6 +1,4 @@
 import {
-  AugmentDecoratorStatementNode,
-  DecoratorExpressionNode,
   Enum,
   EnumMember,
   Interface,
@@ -10,11 +8,15 @@ import {
   Operation,
   Program,
   Scalar,
-  SyntaxKind,
   Type,
   Union,
   UnionVariant,
 } from "@typespec/compiler";
+import {
+  AugmentDecoratorStatementNode,
+  DecoratorExpressionNode,
+  SyntaxKind,
+} from "@typespec/compiler/ast";
 import { DuplicateTracker } from "@typespec/compiler/utils";
 import { createTCGCContext } from "./context.js";
 import { getClientNameOverride } from "./decorators.js";