Replace Newtonsoft.Json with System.Text.Json on all TFMs #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
commented
Jan 6, 2025
|
|
||
| namespace Microsoft.Identity.Client.Cache | ||
| { | ||
| /// <summary> | ||
| /// Contains the results of an ADAL token acquisition. Access Tokens from ADAL are not compatible | ||
| /// with MSAL, only Refresh Tokens are. | ||
| /// </summary> | ||
| [JsonObject] |
There was a problem hiding this comment.
These attributes are no longer needed.
bgavrilMS
commented
Jan 6, 2025
| @@ -1,5 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup Label="Targets required for unit tests to run"> | |||
| <TargetFrameworkNetDesktop462>net462</TargetFrameworkNetDesktop462> | |||
| <TargetFrameworkNetDesktop472>net472</TargetFrameworkNetDesktop472> | |||
There was a problem hiding this comment.
This needs to be reviewed carefully.
bgavrilMS
changed the title
bgavrilMS
force-pushed
the
bogavril/sjt
branch
from
f73835e to
181e87b
Compare
There was a problem hiding this comment.
Copilot reviewed 283 out of 298 changed files in this pull request and generated no comments.
Files not reviewed (15)
- Directory.Packages.props: Language not supported
- build/platform_and_feature_flags.props: Language not supported
- src/client/Microsoft.Identity.Client/Cache/Items/MsalAppMetadataCacheItem.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/AuthScheme/PoP/PopAuthenticationOperation.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/Items/MsalIdTokenCacheItem.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/Items/MsalRefreshTokenCacheItem.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/Items/MsalCredentialCacheItemBase.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/AppConfig/TraceTelemetryConfig.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/TokenCacheDictionarySerializer.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/Items/MsalCacheItemBase.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/ITokenCacheSerializable.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/AppConfig/AbstractApplicationBuilder.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/AppConfig/BaseAbstractApplicationBuilder.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/Items/MsalAccountCacheItem.cs: Evaluated as low risk
- src/client/Microsoft.Identity.Client/Cache/Items/MsalAccessTokenCacheItem.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/client/Microsoft.Identity.Client/Cache/Items/MsalItemWithAdditionalFields.cs:55
- Ensure that the conversion to string correctly handles null values and the filter logic. Verify that the behavior remains consistent with the previous implementation.
string asString = asObj.GetValue<string>();
db87c78 to
d8ac227
Compare
|
bgavrilMS
force-pushed
the
bogavril/sjt
branch
from
d8ac227 to
608d2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4518 and #5056
Changes proposed in this request
remove newtonsoft from MSAL (but not from tests, it's missing some functionality around DeepEquals)
use System.Text.Json version 6.0.11 (in line with other SDKs) on .NET FWK and .NET Standard
use inbuilt System.Text.Json (i.e. version 8) on the rest of the TFMs (like before on net8)
Testing
PCA browser
WAM
Android Browser
Android Broker
Performance impact
Documentation