Discovery calls not being cached

[aleknik]

Core Library

MSAL Node (@azure/msal-node)

Core Library Version

1.14.2

Wrapper Library

Not Applicable

Wrapper Library Version

None

Public or Confidential Client?

Confidential

Description

When sending multiple calls to acquireTokenByClientCredential or acquireTokenOnBehalfOf in short period of time OIDC endpoint is being called for each request instead of reusing the same request.

Error Message

No response

Msal Logs

No response

MSAL Configuration

auth: {
                    clientId: clientId,
                    knownAuthorities: [authority],
                    clientCertificate: {
                        privateKey: cert.privateRSAKey,
                        thumbprint: cert.publicCER.getThumbprintHex(),
                        x5c: cert.publicCER.asPEM()
                    }
                },
                system: {
                    networkClient: this.httpModule
                }

Relevant Code Snippets

Send multiple requests on a for loop to acquireTokenByClientCredential or acquireTokenOnBehalfOf and log http requests made to OIDC

Reproduction Steps

When sending multiple calls to acquireTokenByClientCredential or acquireTokenOnBehalfOf in short period of time OIDC endpoint is being called for each request instead of reusing the same request.

Expected Behavior

One call is send to OIDC and response is reused across other calls

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

None (Server)

Regression

No response

Source

Internal (Microsoft)

[bgavrilMS]

@hectormmg @thomas-oo @sameerag - do you have any suggestions on how to fix this ? It is common for web sites / web apis to create a confidential client app object for each request, possibly with a different tenant_id. But this leads to a lot of OIDC calls. Explicit cache might not be used.

Is it possible to cache OIDC metadata in some static variable ?

[hectormmg]

@sameerag may have more context here. We generally try to stay away from static variables, but we do leverage a sort of request cache in msal-browser that prevents multiple identical requests from being sent out to the network. Is this something we can do in-memory? In other words, if the request thumbprint matches one stored in the in-memory cache, we return the cached response instead of sending out an identical request.

@aleknik This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.