Replace remaining uses of chrono::Duration with chrono::TimeDelta

Author: BBaoVanC

CHANGELOG.md

@@ -9,6 +9,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Internal Changes
 
+All:
+
+- Replace remaining uses of `chrono::Duration` type alias with the actual type
+  (`chrono::TimeDelta`)
+  - This shouldn't be a breaking change even though `cargo-public-api` says
+    so; I can't imagine any way existing calling code would be broken. The only
+    changed public api is `FileBackend::create_upload` where it is used as a
+    parameter.
+
 bobashare:
 
 - Merge many separated module files into inline `pub mod ... {` definitions

bobashare-web/src/api/v1/upload.rs

@@ -11,7 +11,7 @@ use axum::{
 };
 use axum_extra::{extract::WithRejection, typed_header::TypedHeaderRejection, TypedHeader};
 use bobashare::{generate_randomized_id, storage::file::CreateUploadError};
-use chrono::{DateTime, Duration, Utc};
+use chrono::{DateTime, TimeDelta, Utc};
 use displaydoc::Display;
 use futures_util::TryStreamExt;
 use headers::{ContentLength, ContentType};
@@ -183,7 +183,7 @@ pub async fn put(
                 None
             } else {
                 Some(
-                    Duration::from_std(str_to_duration(expiry).map_err(|e| {
+                    TimeDelta::from_std(str_to_duration(expiry).map_err(|e| {
                         UploadError::ParseHeader {
                             name: String::from("Bobashare-Expiry"),
                             source: anyhow::Error::new(e).context("error parsing duration string"),

bobashare-web/src/views/display.rs

@@ -8,7 +8,7 @@ use axum::{
     response::IntoResponse,
 };
 use bobashare::storage::{file::OpenUploadError, handle::UploadHandle};
-use chrono::{DateTime, Duration, Utc};
+use chrono::{DateTime, TimeDelta, Utc};
 use displaydoc::Display;
 use hyper::{header, StatusCode};
 use mime::Mime;
@@ -68,7 +68,7 @@ pub struct DisplayTemplate<'s> {
     pub id: String,
     pub filename: String,
     pub expiry_date: Option<DateTime<Utc>>,
-    pub expiry_relative: Option<Duration>,
+    pub expiry_relative: Option<TimeDelta>,
     pub size: u64,
     pub mimetype: Mime,
     pub contents: DisplayType,

bobashare-web/src/views/mod.rs

@@ -9,7 +9,7 @@ use axum::{
     routing::get,
     Router,
 };
-use chrono::Duration;
+use chrono::TimeDelta;
 use hyper::StatusCode;
 use tracing::{event, Level};
 use url::Url;
@@ -32,7 +32,7 @@ pub struct TemplateState<'s> {
     version: &'static str,
     base_url: &'s Url,
     max_file_size: u64,
-    max_expiry: Option<Duration>,
+    max_expiry: Option<TimeDelta>,
     extra_footer_text: Option<&'s str>,
     about_page: Option<&'s Path>,
 

bobashare/public-api.txt

@@ -513,7 +513,7 @@ pub bobashare::storage::file::FileBackend::path: std::path::PathBuf
 impl bobashare::storage::file::FileBackend
 pub async fn bobashare::storage::file::FileBackend::cleanup(&self) -> core::result::Result<(), bobashare::storage::file::CleanupError>
 impl bobashare::storage::file::FileBackend
-pub async fn bobashare::storage::file::FileBackend::create_upload<S: core::convert::AsRef<str>>(&self, id: S, filename: S, mimetype: mime::Mime, expiry: core::option::Option<chrono::Duration>, delete_key: core::option::Option<alloc::string::String>) -> core::result::Result<bobashare::storage::handle::UploadHandle, bobashare::storage::file::CreateUploadError>
+pub async fn bobashare::storage::file::FileBackend::create_upload<S: core::convert::AsRef<str>>(&self, id: S, filename: S, mimetype: mime::Mime, expiry: core::option::Option<chrono::time_delta::TimeDelta>, delete_key: core::option::Option<alloc::string::String>) -> core::result::Result<bobashare::storage::handle::UploadHandle, bobashare::storage::file::CreateUploadError>
 impl bobashare::storage::file::FileBackend
 pub async fn bobashare::storage::file::FileBackend::delete_upload<S: core::convert::AsRef<str>>(&self, id: S) -> core::result::Result<(), bobashare::storage::file::DeleteUploadError>
 impl bobashare::storage::file::FileBackend

bobashare/src/storage/file.rs

@@ -2,7 +2,7 @@
 
 use std::path::PathBuf;
 
-use chrono::{prelude::*, Duration};
+use chrono::{prelude::*, TimeDelta};
 use displaydoc::Display;
 use mime::Mime;
 use thiserror::Error;
@@ -97,7 +97,7 @@ impl FileBackend {
         id: S,
         filename: S,
         mimetype: Mime,
-        expiry: Option<Duration>,
+        expiry: Option<TimeDelta>,
         delete_key: Option<String>,
     ) -> Result<UploadHandle, CreateUploadError> {
         let creation_date = Utc::now();