Improve scaffold wall emitter placement

Had this sitting in my unstaged changes for a while, don't remember how finished it was.

This will fix #4106

Author: vrad-exe

packages/scaffold/info.txt

@@ -131,6 +131,8 @@
 		"" "* The first item will use its Start Enabled property as well as inputs to control the platform.  "
 		"" "* Enable Start Reversed to make the platform oscillate between endpoints, instead of stopping.  "
 		"" "* The platform is always positioned upright."
+		"" "* The various movement handle positions for wall emitters have been adjusted to produce more useful results, and may not exactly match what is displayed in the editor."
+		"" "* When placed on the floor, the platform will be lower so that it can be jumped onto."
 		}
 	"Version"
 		{

packages/scaffold/items/wall/editoritems.txt

@@ -21,7 +21,7 @@
 				"SOUND_DELETED"					"P2Editor.RemoveOther"
 			}
 		}
-		"MovementHandle"        "HANDLE_6_POSITIONS"
+		"MovementHandle"        "HANDLE_8_POSITIONS"
 		"InvalidSurface"		"CEILING"
 	}
 	"Properties"

packages/scaffold/items/wall_clean.cfg

@@ -7,17 +7,76 @@
 
 		"Condition"
 			{
-			"Orientation" "up"
+			"Orientation" "floor"
 			// On the floor, we move the platform to be right next to the emitter so you
 			// can jump up to it.
 			"Result"
 				{
 				"ChangeInstance" "instances/BEE2/clean/items/scaffold/floor_emitter.vmf"
-				"OffsetInst" "0 0 -56"
+				// Move 16 units towards center of voxel
+				"OffsetInst" "16 0 -56"
 				}
 			"Else"
 				{
 				"ChangeInstance" "instances/BEE2/clean/items/scaffold/wall_emitter.vmf"
+
+				// Shift the various sub-voxel handle positions to be more useful
+				"Condition"
+					{
+					// -X pointing up - top positions, shift 16 units towards +X (down)
+					"Orientation"
+						{
+						"direction"     "up"
+						"from_dir"      "-1 0 0"
+						}
+					"Result"
+						{
+						"OffsetInst" "16 0 0"
+						}
+					}
+				"Condition"
+					{
+					// -X pointing down - bottom positions, shift 16 towards -X (down)
+					"Orientation"
+						{
+						"direction"     "down"
+						"from_dir"      "-1 0 0"
+						}
+					"Result"
+						{
+						"OffsetInst" "-16 0 0"
+						}
+					}
+				"Condition"
+					{
+					// +Y pointing up - left positions, shift 16 out and 32 towards +Y (up)
+					"Orientation"
+						{
+						"direction"     "up"
+						"from_dir"      "0 1 0"
+						}
+					"Result"
+						{
+						"OffsetInst" "-16 32 0"
+						}
+					}
+				"Condition"
+					{
+					// +Y pointing down - right positions, shift 16 out and 32 towards -Y (up)
+					"Orientation"
+						{
+						"direction"     "down"
+						"from_dir"      "0 1 0"
+						}
+					"Result"
+						{
+						"OffsetInst" "-16 -32 0"
+						}
+					}
+				"TemplateBrush"
+					{
+					"ID" "BEE2_UNST_SCAFFOLD_BACKING_CLEAN"
+					}
 				}
 			}
 		"Result"