Skip to content

Commit 9d759bb

Browse files
authored
Merge pull request #10 from BIOP/version-fix
Version fix
2 parents 8d62465 + 721f81b commit 9d759bb

6 files changed

Lines changed: 28 additions & 19 deletions

File tree

build.gradle.kts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import java.util.Date
2+
import java.text.SimpleDateFormat
3+
14
plugins {
25
`java-library`
36
// To create a shadow/fat jar, including dependencies
@@ -23,7 +26,7 @@ description = "QuPath extension to use Warpy"
2326

2427
group = "ch.epfl.biop"
2528
// artifact = "qupath-extension-warpy"
26-
version = "0.2.5-SNAPSHOT"
29+
version = "0.2.5"
2730

2831
dependencies {
2932
val qupathVersion = "0.4.3" // For now
@@ -111,5 +114,14 @@ publishing {
111114
}
112115
}
113116

117+
tasks.jar {
118+
// Important to set version so this can be queried within QuPath
119+
manifest {
120+
attributes[ "Implementation-Vendor" ] = "Warpy developers"
121+
attributes[ "Implementation-Version" ] = project.version
122+
attributes[ "QuPath-build-time" ] = SimpleDateFormat("yyyy-MM-dd, HH:mm").format(Date())
123+
}
124+
}
125+
114126
val SoftwareComponentContainer.java
115127
get() = components.getByName("java") as AdhocComponentWithVariants

src/main/java/net/imglib2/realtransform/RealTransformSerializer.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.slf4j.Logger;
99
import org.slf4j.LoggerFactory;
1010
import qupath.ext.biop.warpy.Warpy;
11+
import qupath.ext.biop.warpy.WarpyExtension;
1112
import qupath.ext.imagecombinerwarpy.gui.RealTransformInterpolation;
1213
import qupath.lib.io.GsonTools;
1314

@@ -66,8 +67,8 @@ public RealTransformInterpolation deserialize(JsonElement jsonElement, Type type
6667
rtis.setInterpolation(interpolation);
6768
String version = obj.get("version").getAsString();
6869
rtis.setVersion(version);
69-
if (!version.equals(Warpy.version)) {
70-
logger.warn("Warpy version "+Warpy.version+" different from ImageServer "+version);
70+
if (!version.equals(WarpyExtension.getWarpyVersion())) {
71+
logger.warn("Warpy version "+WarpyExtension.getWarpyVersion()+" different from ImageServer "+version);
7172
}
7273
RealTransform transform = RealTransformSerializer.getRealTransformAdapter().fromJson(obj.get("transform"), RealTransform.class);
7374
rtis.setTransform(transform);

src/main/java/qupath/ext/biop/warpy/Warpy.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,7 @@
6262
*/
6363

6464
public class Warpy {
65-
66-
final static public String version = "0.2.3-SNAPSHOT";
67-
65+
6866
// Logger class that plays well with QuPath
6967
final private static Logger logger = LoggerFactory.getLogger(Warpy.class);
7068

src/main/java/qupath/ext/biop/warpy/WarpyExtension.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import org.slf4j.Logger;
44
import org.slf4j.LoggerFactory;
5+
import qupath.lib.common.GeneralTools;
56
import qupath.lib.common.Version;
67
import qupath.lib.gui.QuPathGUI;
78
import qupath.lib.gui.extensions.GitHubProject;
@@ -42,8 +43,8 @@ public Version getQuPathVersion() {
4243
return QuPathExtension.super.getQuPathVersion();
4344
}
4445

45-
@Override
46-
public Version getVersion() {
47-
return Version.parse(Warpy.version);
46+
public static String getWarpyVersion() {
47+
String packageVersion = GeneralTools.getPackageVersion(WarpyExtension.class);
48+
return Version.parse(packageVersion).toString();
4849
}
49-
}
50+
}

src/main/java/qupath/ext/imagecombinerwarpy/ImageCombinerWarpyExtension.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,11 +153,7 @@ public GitHubRepo getRepository() {
153153

154154
@Override
155155
public Version getQuPathVersion() {
156-
return Version.parse("0.3.1");
156+
return QuPathExtension.super.getQuPathVersion();
157157
}
158158

159-
@Override
160-
public Version getVersion() {
161-
return Version.parse(Warpy.version);
162-
}
163159
}

src/main/java/qupath/ext/imagecombinerwarpy/gui/RealTransformInterpolation.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import net.imglib2.realtransform.RealTransform;
1818
import qupath.ext.biop.warpy.Warpy;
19+
import qupath.ext.biop.warpy.WarpyExtension;
1920

2021
public class RealTransformInterpolation {
2122

@@ -27,9 +28,9 @@ public class RealTransformInterpolation {
2728
private RealTransform transform;
2829

2930
String version;
30-
31+
3132
public RealTransformInterpolation() {
32-
version = Warpy.version;
33+
version = WarpyExtension.getWarpyVersion();
3334
}
3435

3536
public String getVersion() {
@@ -41,15 +42,15 @@ public void setVersion(String version) {
4142
}
4243

4344
public RealTransformInterpolation(RealTransformInterpolation transformInterpolateSequence) {
44-
version = Warpy.version;
45+
version = WarpyExtension.getWarpyVersion();
4546
int interpolation = transformInterpolateSequence.getInterpolation();
4647
if (isValidInterpolation(interpolation))
4748
this.interpolation = interpolation;
4849
this.transform = transformInterpolateSequence.getTransform();
4950
}
5051

5152
public RealTransformInterpolation(RealTransform transform, int interpolation) {
52-
version = Warpy.version;
53+
version = WarpyExtension.getWarpyVersion();
5354
if (isValidInterpolation(interpolation))
5455
this.interpolation = interpolation;
5556

0 commit comments

Comments
 (0)