Skip to content

Commit ba497f3

Browse files
committed
Implement #75 Add reverted extensions blade.pug and jade.pug
1 parent 8854d79 commit ba497f3

3 files changed

Lines changed: 28 additions & 7 deletions

File tree

src/ServiceProvider.php

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,11 +239,28 @@ public function registerPugCompiler($subExtension = '')
239239
return new CompilerEngine($this->app['Bkwld\LaravelPug\Pug' . ucfirst(ltrim($subExtension, '.')) . 'Compiler']);
240240
});
241241

242-
// Add extensions
243-
$this->app['view']->addExtension('pug' . $subExtension, 'pug' . $subExtension);
244-
$this->app['view']->addExtension('pug' . $subExtension . '.php', 'pug' . $subExtension);
245-
$this->app['view']->addExtension('jade' . $subExtension, 'pug' . $subExtension);
246-
$this->app['view']->addExtension('jade' . $subExtension . '.php', 'pug' . $subExtension);
242+
$mainExtension = 'pug' . $subExtension;
243+
$extensions = array(
244+
// Pug extensions
245+
$mainExtension,
246+
$mainExtension . '.php',
247+
// Legacy jade extensions
248+
'jade' . $subExtension,
249+
'jade' . $subExtension . '.php',
250+
);
251+
252+
if ($subExtension !== '') {
253+
$subExtensionPrefix = substr($subExtension, 1) . '.';
254+
255+
$extensions[] = $subExtensionPrefix . 'pug';
256+
$extensions[] = $subExtensionPrefix . 'pug.php';
257+
$extensions[] = $subExtensionPrefix . 'jade';
258+
$extensions[] = $subExtensionPrefix . 'jade.php';
259+
}
260+
261+
foreach ($extensions as $extension) {
262+
$this->app['view']->addExtension($extension, $mainExtension);
263+
}
247264
}
248265

249266
/**
@@ -257,7 +274,7 @@ public function registerPugBladeCompiler()
257274
}
258275

259276
/**
260-
* Get the configuration, which is keyed differently in L5 vs l4.
277+
* Get the configuration, which is keyed differently in L5 vs L4.
261278
*
262279
* @return array
263280
*/

tests/BladeDirectivesTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,10 @@ public function testCustomDirective()
185185

186186
self::assertSame(
187187
[
188+
'blade.jade.php' => 'pug.blade',
189+
'blade.jade' => 'pug.blade',
190+
'blade.pug.php' => 'pug.blade',
191+
'blade.pug' => 'pug.blade',
188192
'jade.blade.php' => 'pug.blade',
189193
'jade.blade' => 'pug.blade',
190194
'pug.blade.php' => 'pug.blade',

tests/ServiceProviderTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ public function testBoot()
344344
$this->provider->boot();
345345

346346
self::assertArraySubset(
347-
['pug', 'pug.php', 'jade', 'jade.php', 'pug.blade', 'pug.blade.php', 'jade.blade', 'jade.blade.php'],
347+
['pug', 'pug.php', 'jade', 'jade.php', 'pug.blade', 'pug.blade.php', 'jade.blade', 'jade.blade.php', 'blade.pug', 'blade.pug.php', 'blade.jade', 'blade.jade.php'],
348348
array_keys($view->getExtensions())
349349
);
350350
self::assertSame('bkwld/laravel-pug', $this->provider->getCurrentPackage());

0 commit comments

Comments
 (0)