Avoid implicit 'this' capture in GPU lambda function

Author: oshapoval

Source/Particles/Resampling/ParticleSplitting.cpp

@@ -44,10 +44,8 @@ ParticleSplitting::ParticleSplitting (const std::string& species_name)
         "  - position_axes_aligned_split\n"
         "  - position_velocity_aligned_split.\n");
 
-    if (!m_resampling_random_splitting_angle) {
-        utils::parser::queryWithParser(
-            pp_species_name, "resampling_splitting_angle", m_splitting_angle);
-    }
+    utils::parser::queryWithParser(
+        pp_species_name, "resampling_splitting_angle", m_splitting_angle);
 }
 void ParticleSplitting::operator() (
     const amrex::Geometry& geom_lev, WarpXParIter& pti,
@@ -85,6 +83,8 @@ void ParticleSplitting::operator() (
     }
 
     const auto min_ppc = m_min_ppc;
+    const auto resampling_random_splitting_angle = m_resampling_random_splitting_angle;
+    const amrex::Real splitting_angle_fixed = m_splitting_angle;
 
     amrex::Gpu::DeviceVector<int> n_new_children_per_cell(n_cells);
     int* num_new_children_ptr = n_new_children_per_cell.data();
@@ -170,9 +170,9 @@ void ParticleSplitting::operator() (
             amrex::ParticleReal offset_z = dx[2] * inv_split;
 #endif
 
-            const auto resampling_random_splitting_angle = m_resampling_random_splitting_angle;
-            const amrex::Real splitting_angle = resampling_random_splitting_angle ?
-                amrex::Random(engine) * 2.0_rt * MathConst::pi : m_splitting_angle;
+            auto phi = amrex::Random(engine) * 2.0_rt * MathConst::pi;
+
+            amrex::Real splitting_angle = resampling_random_splitting_angle ? phi : splitting_angle_fixed;
 
             // Starting index for new children particles for i_cell
             const int new_particle_start = num_particles_tile + offset_ptr[i_cell];