Skip to content

Commit af3b2f0

Browse files
EZoniEZoni
committed
Check skip flag in each job step
1 parent dbb7012 commit af3b2f0

File tree

10 files changed

+146
-49
lines changed

10 files changed

+146
-49
lines changed

‎.github/workflows/clang_sanitizers.yml‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,26 +32,30 @@ jobs:
3232
name: Clang UB sanitizer
3333
runs-on: ubuntu-24.04
3434
needs: skip_checks
35-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
35+
if: ${{ github.event.pull_request.draft == false }}
3636
env:
3737
CC: clang
3838
CXX: clang++
3939
# On CI for this test, Ninja is slower than the default:
4040
#CMAKE_GENERATOR: Ninja
4141
steps:
4242
- name: Checkout code
43+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4344
uses: actions/checkout@v4
4445
- name: Install dependencies
46+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4547
run: |
4648
.github/workflows/dependencies/clang.sh 17
4749
- name: CCache Cache
50+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4851
uses: actions/cache@v4
4952
with:
5053
path: ~/.cache/ccache
5154
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
5255
restore-keys: |
5356
ccache-${{ github.workflow }}-${{ github.job }}-git-
5457
- name: Build WarpX
58+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
5559
run: |
5660
export CCACHE_COMPRESS=1
5761
export CCACHE_COMPRESSLEVEL=10
@@ -75,6 +79,7 @@ jobs:
7579
ccache -s
7680
du -hs ~/.cache/ccache
7781
- name: Run with UB sanitizer
82+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
7883
run: |
7984
export OMP_NUM_THREADS=2
8085
#MPI implementations often leak memory
@@ -89,26 +94,30 @@ jobs:
8994
name: Clang thread sanitizer
9095
runs-on: ubuntu-24.04
9196
needs: skip_checks
92-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
97+
if: ${{ github.event.pull_request.draft == false }}
9398
env:
9499
CC: clang
95100
CXX: clang++
96101
# On CI for this test, Ninja is slower than the default:
97102
#CMAKE_GENERATOR: Ninja
98103
steps:
99104
- name: Checkout code
105+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
100106
uses: actions/checkout@v4
101107
- name: Install dependencies
108+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
102109
run: |
103110
.github/workflows/dependencies/clang.sh 17
104111
- name: CCache Cache
112+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
105113
uses: actions/cache@v4
106114
with:
107115
path: ~/.cache/ccache
108116
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
109117
restore-keys: |
110118
ccache-${{ github.workflow }}-${{ github.job }}-git-
111119
- name: Build WarpX
120+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
112121
run: |
113122
export CCACHE_COMPRESS=1
114123
export CCACHE_COMPRESSLEVEL=10
@@ -132,6 +141,7 @@ jobs:
132141
ccache -s
133142
du -hs ~/.cache/ccache
134143
- name: Run with thread sanitizer
144+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
135145
run: |
136146
# Disabling the gds/shmem component by using gds/hash instead
137147
# is required to avoid issues with shared memory.

‎.github/workflows/codeql.yml‎

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -13,27 +13,10 @@ concurrency:
1313
cancel-in-progress: true
1414

1515
jobs:
16-
skip_checks:
17-
name: Analyze PR
18-
runs-on: ubuntu-latest
19-
steps:
20-
- name: Checkout code
21-
uses: actions/checkout@v4
22-
with:
23-
fetch-depth: 0
24-
- name: Skip checks?
25-
run: |
26-
.github/workflows/scripts/check_diff.sh \
27-
${{ github.event.pull_request.head.ref }} \
28-
${{ github.event.pull_request.base.ref }} \
29-
${{ github.event.pull_request.head.repo.clone_url }}
30-
outputs:
31-
skip: ${{ env.SKIP_CHECKS }}
3216
analyze:
33-
name: Query code
17+
name: Analyze
3418
runs-on: ubuntu-24.04
35-
needs: skip_checks
36-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
19+
if: github.event.pull_request.draft == false
3720
permissions:
3821
actions: read
3922
contents: read
@@ -50,7 +33,7 @@ jobs:
5033
with:
5134
python-version: '3.x'
5235
- name: Install Packages (C++)
53-
if: ${{ matrix.language == 'cpp' }}
36+
if: matrix.language == 'cpp'
5437
run: |
5538
sudo apt-get update
5639
sudo apt-get install --yes cmake openmpi-bin libopenmpi-dev libhdf5-openmpi-dev libadios-openmpi-dev ccache
@@ -60,15 +43,15 @@ jobs:
6043
python -m pip install --upgrade cmake
6144
python -m pipx install cmake
6245
- name: Set Up Cache
63-
if: ${{ matrix.language == 'cpp' }}
46+
if: matrix.language == 'cpp'
6447
uses: actions/cache@v4
6548
with:
6649
path: ~/.cache/ccache
6750
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
6851
restore-keys: |
6952
ccache-${{ github.workflow }}-${{ github.job }}-git-
7053
- name: Configure (C++)
71-
if: ${{ matrix.language == 'cpp' }}
54+
if: matrix.language == 'cpp'
7255
run: |
7356
cmake -S . -B build -DWarpX_OPENPMD=ON
7457
- name: Initialize CodeQL
@@ -78,10 +61,10 @@ jobs:
7861
languages: ${{ matrix.language }}
7962
queries: +security-and-quality
8063
- name: Build (py)
81-
if: ${{ matrix.language == 'python' }}
64+
if: matrix.language == 'python'
8265
uses: github/codeql-action/autobuild@v3
8366
- name: Build (C++)
84-
if: ${{ matrix.language == 'cpp' }}
67+
if: matrix.language == 'cpp'
8568
run: |
8669
export CCACHE_COMPRESS=1
8770
export CCACHE_COMPRESSLEVEL=10

‎.github/workflows/cuda.yml‎

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,28 +35,33 @@ jobs:
3535
name: NVCC SP
3636
runs-on: ubuntu-22.04
3737
needs: skip_checks
38-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
38+
if: ${{ github.event.pull_request.draft == false }}
3939
env:
4040
CXXFLAGS: "-Werror"
4141
CMAKE_GENERATOR: Ninja
4242
steps:
4343
- name: Checkout code
44+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4445
uses: actions/checkout@v4
4546
- name: Install Python
47+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4648
uses: actions/setup-python@v5
4749
with:
4850
python-version: '3.x'
4951
- name: Install dependencies
52+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
5053
run: |
5154
.github/workflows/dependencies/nvcc.sh 11.7
5255
- name: CCache Cache
56+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
5357
uses: actions/cache@v4
5458
with:
5559
path: ~/.cache/ccache
5660
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
5761
restore-keys: |
5862
ccache-${{ github.workflow }}-${{ github.job }}-git-
5963
- name: Install openPMD-api
64+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
6065
run: |
6166
export CCACHE_COMPRESS=1
6267
export CCACHE_COMPRESSLEVEL=10
@@ -76,6 +81,7 @@ jobs:
7681
-DCMAKE_CXX_COMPILER_LAUNCHER=$(which ccache) \
7782
-DCMAKE_VERBOSE_MAKEFILE=ON
7883
- name: Build WarpX
84+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
7985
run: |
8086
export CCACHE_COMPRESS=1
8187
export CCACHE_COMPRESSLEVEL=10
@@ -110,21 +116,25 @@ jobs:
110116
name: NVCC GNU Make
111117
runs-on: ubuntu-22.04
112118
needs: skip_checks
113-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
119+
if: ${{ github.event.pull_request.draft == false }}
114120
steps:
115121
- name: Checkout code
122+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
116123
uses: actions/checkout@v4
117124
- name: Install dependencies
125+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
118126
run: |
119127
.github/workflows/dependencies/nvcc.sh 11.7
120128
- name: CCache Cache
129+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
121130
uses: actions/cache@v4
122131
with:
123132
path: ~/.cache/ccache
124133
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
125134
restore-keys: |
126135
ccache-${{ github.workflow }}-${{ github.job }}-git-
127136
- name: Build WarpX
137+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
128138
run: |
129139
export CCACHE_COMPRESS=1
130140
export CCACHE_COMPRESSLEVEL=10
@@ -143,23 +153,27 @@ jobs:
143153
name: NVHPC
144154
runs-on: ubuntu-24.04
145155
needs: skip_checks
146-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
156+
if: ${{ github.event.pull_request.draft == false }}
147157
#env:
148158
# # For NVHPC, Ninja is slower than the default:
149159
# CMAKE_GENERATOR: Ninja
150160
steps:
151161
- name: Checkout code
162+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
152163
uses: actions/checkout@v4
153164
- name: Dependencies
165+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
154166
run: .github/workflows/dependencies/nvhpc.sh 25.1
155167
- name: CCache Cache
168+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
156169
uses: actions/cache@v4
157170
with:
158171
path: ~/.cache/ccache
159172
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
160173
restore-keys: |
161174
ccache-${{ github.workflow }}-${{ github.job }}-git-
162175
- name: Build & Install
176+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
163177
run: |
164178
export CCACHE_COMPRESS=1
165179
export CCACHE_COMPRESSLEVEL=10

‎.github/workflows/hip.yml‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,25 @@ jobs:
3434
CXXFLAGS: "-Werror -Wno-deprecated-declarations -Wno-error=pass-failed"
3535
CMAKE_GENERATOR: Ninja
3636
needs: skip_checks
37-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
37+
if: ${{ github.event.pull_request.draft == false }}
3838
steps:
3939
- name: Checkout code
40+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4041
uses: actions/checkout@v4
4142
- name: Install dependencies
43+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4244
shell: bash
4345
run: .github/workflows/dependencies/hip.sh 6.3.2
4446
- name: CCache Cache
47+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
4548
uses: actions/cache@v4
4649
with:
4750
path: ~/.cache/ccache
4851
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
4952
restore-keys: |
5053
ccache-${{ github.workflow }}-${{ github.job }}-git-
5154
- name: Build WarpX
55+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
5256
shell: bash
5357
run: |
5458
export CCACHE_COMPRESS=1
@@ -86,21 +90,25 @@ jobs:
8690
CXXFLAGS: "-Werror -Wno-deprecated-declarations -Wno-error=pass-failed"
8791
CMAKE_GENERATOR: Ninja
8892
needs: skip_checks
89-
if: ${{ github.event.pull_request.draft == false && needs.skip_checks.outputs.skip == 'false' }}
93+
if: ${{ github.event.pull_request.draft == false }}
9094
steps:
9195
- name: Checkout code
96+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
9297
uses: actions/checkout@v4
9398
- name: Install dependencies
99+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
94100
shell: bash
95101
run: .github/workflows/dependencies/hip.sh 6.3.2
96102
- name: CCache Cache
103+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
97104
uses: actions/cache@v4
98105
with:
99106
path: ~/.cache/ccache
100107
key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }}
101108
restore-keys: |
102109
ccache-${{ github.workflow }}-${{ github.job }}-git-
103110
- name: Build WarpX
111+
if: ${{ needs.skip_checks.outputs.skip == 'false' }}
104112
shell: bash
105113
run: |
106114
export CCACHE_COMPRESS=1

0 commit comments

Comments
 (0)