Skip to content

Commit af69d38

Browse files
authored
ci: tune cpp-linter to use repo style and reduce PR noise (#297)
Configure the `cpp-linter` workflow to read formatting rules from the repository and make its PR feedback less noisy. This makes the formatting source of truth live in the repository instead of being hard-coded in the workflow, which gives us a cleaner path to adjust style over time. It also shifts `cpp-linter` feedback away from noisy PR comment churn and toward the GitHub Actions UI, while still failing the job when checks fail.
1 parent 71abd09 commit af69d38

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

.clang-format

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
BasedOnStyle: Microsoft

.github/workflows/build-pull-request.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,15 @@ jobs:
2929
env:
3030
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3131
with:
32-
style: microsoft
32+
style: file
3333
ignore: include/argparse
3434
lines-changed-only: true
3535
thread-comments: update
36-
format-review: true
36+
format-review: false
3737
tidy-checks: '-*'
38+
tidy-review: false
39+
step-summary: true
40+
file-annotations: true
3841

3942
- name: Fail fast?!
4043
if: steps.linter.outputs.checks-failed != 0

0 commit comments

Comments
 (0)