Skip to content

Commit 13b3f04

Browse files
authored
Merge pull request #7167 from BOINC/dpa_mem_usage3
client: log messages: don't say 'virtual size' when you mean 'swap usage'
2 parents 766f6d0 + e1f00ad commit 13b3f04

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

client/client_state.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,9 @@ void CLIENT_STATE::show_host_info() {
230230
nbytes_to_string(host_info.m_nbytes, 0, buf, sizeof(buf));
231231
if (is_swap_defined()) {
232232
nbytes_to_string(host_info.m_swap, 0, buf2, sizeof(buf2));
233-
msg_printf(NULL, MSG_INFO, "Memory: %s physical, %s virtual", buf, buf2);
233+
msg_printf(NULL, MSG_INFO, "Memory: %s RAM, %s swap space", buf, buf2);
234234
} else {
235-
msg_printf(NULL, MSG_INFO, "Memory: %s physical", buf);
235+
msg_printf(NULL, MSG_INFO, "Memory: %s RAM", buf);
236236
}
237237

238238
nbytes_to_string(host_info.d_total, 0, buf, sizeof(buf));

client/cpu_sched.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,7 @@ bool CLIENT_STATE::swap_limit_check() {
850850
if (swap_usage > swap_limit) {
851851
if (log_flags.cpu_sched_debug) {
852852
msg_printf(NULL, MSG_INFO,
853-
"[cpu_sched_debug] virtual size limit exceeded: %.2f GB > %.2f GB",
853+
"[cpu_sched_debug] swap usage limit exceeded: %.2f GB > %.2f GB",
854854
swap_usage/GIGA, swap_limit/GIGA
855855
);
856856
}
@@ -1494,18 +1494,18 @@ bool CLIENT_STATE::enforce_run_list(vector<RESULT*>& run_list) {
14941494
}
14951495
}
14961496

1497-
// skip jobs whose 'expected working set size' (EWSS)
1498-
// is too large to fit in available RAM,
1499-
// or whose swap size is too large for available swap space.
1497+
// skip jobs whose 'expected resident set size' (erss)
1498+
// exceeds available RAM,
1499+
// or whose swap usage exceeds available swap space.
15001500
//
1501-
// To compute EWSS, we start with
1502-
// - if the job has already run, its recent average WSS
1501+
// To compute erss, we start with
1502+
// - if the job has already run, its recent average RSS
15031503
// - else if other jobs of this app version have run recently,
1504-
// the max of their WSSs
1504+
// the max of their RSSs
15051505
// - else the WU's rsc_memory_bound
15061506
// If project->strict_memory_bound is set,
15071507
// we max the above with wu.rsc_memory_bound.
1508-
// This is to handle apps (like CPDN) whose WSS is small for a while
1508+
// This is to handle apps (like CPDN) whose RSS is small for a while
15091509
// and then gets big.
15101510
//
15111511
double erss = 0;
@@ -1544,7 +1544,7 @@ bool CLIENT_STATE::enforce_run_list(vector<RESULT*>& run_list) {
15441544
}
15451545
if (log_flags.cpu_sched_debug || log_flags.mem_usage_debug) {
15461546
msg_printf(rp->project, MSG_INFO,
1547-
"[cpu_sched_debug] skipping %s: virtual size (%.2f GB) exceeds swap left (%.2f GB)",
1547+
"[cpu_sched_debug] skipping %s: swap usage (%.2f GB) exceeds swap left (%.2f GB)",
15481548
rp->name, eswap/GIGA, swap_left/GIGA
15491549
);
15501550
}

0 commit comments

Comments
 (0)