Copilot suggestions (no functional changes)

Author: davidpanderson

client/acct_mgr.cpp

@@ -801,6 +801,11 @@ void ACCT_MGR_OP::handle_reply(int http_op_retval) {
                     if (acct.suspend.present && acct.suspend.value) {
                         pp->suspend();
                     }
+
+                    // The AM supplies initial accounting info
+                    // (in case the client was previously attached,
+                    // then detached).
+                    //
                     if (gstate.acct_mgr_info.dynamic) {
                         pp->user_expavg_credit = acct.user_avg_ec;
                         pp->user_total_credit = acct.user_total_ec;

client/acct_mgr.h

@@ -161,7 +161,8 @@ struct AM_ACCOUNT {
     OPTIONAL_BOOL abort_not_started;
     double user_avg_ec;
     double user_total_ec;
-    // the following present if client not already attached
+    // the following supplied by dynamic AM if client not already attached
+    // to the project
     double cpu_ec;
     double cpu_time;
     double gpu_ec;

client/project.h

@@ -121,7 +121,9 @@ struct PROJECT : PROJ_AM {
         // and this should go to 1.
         // But we need to keep it around for older projects
 
-    // accounting info for dynamic account managers;
+    // accounting info for use with dynamic account managers;
+    // obtained from the AM on attach,
+    // updated by the client, and reported in AM RPCs
     //
     double cpu_ec;      // estimated credit
     double cpu_time;    // device/seconds

client/scheduler_op.cpp

@@ -614,10 +614,11 @@ int SCHEDULER_REPLY::parse(FILE* in, PROJECT* project) {
         }
     }
 
-    // if project is attached via a dynamic AM (like Science United)
-    // we get user credit from the AM, not the project
+    // if project is attached via a dynamic AM (like Science United),
+    // ignore project-supplied user credit;
+    // we get it from the AM, not the project
     //
-    bool ignore_host_credit = project->attached_via_acct_mgr && gstate.acct_mgr_info.dynamic;
+    bool ignore_user_credit = project->attached_via_acct_mgr && gstate.acct_mgr_info.dynamic;
 
     // First line should either be tag (HTTP 1.0) or
     // hex length of response (HTTP 1.1)
@@ -673,8 +674,8 @@ int SCHEDULER_REPLY::parse(FILE* in, PROJECT* project) {
         }
         else if (xp.parse_str("symstore", project->symstore, sizeof(project->symstore))) continue;
         else if (xp.parse_str("user_name", project->user_name, sizeof(project->user_name))) continue;
-        else if (!ignore_host_credit && xp.parse_double("user_total_credit", project->user_total_credit)) continue;
-        else if (!ignore_host_credit && xp.parse_double("user_expavg_credit", project->user_expavg_credit)) continue;
+        else if (!ignore_user_credit && xp.parse_double("user_total_credit", project->user_total_credit)) continue;
+        else if (!ignore_user_credit && xp.parse_double("user_expavg_credit", project->user_expavg_credit)) continue;
         else if (xp.parse_double("user_create_time", project->user_create_time)) continue;
         else if (xp.parse_double("cpid_time", cpid_time)) continue;
         else if (xp.parse_str("team_name", project->team_name, sizeof(project->team_name))) continue;