Merge pull request #6822 from BOINC/dpa_for_lib

lib: use modern for() syntax

Author: AenBleidd

lib/app_ipc.cpp

@@ -1,6 +1,6 @@
 // This file is part of BOINC.
-// http://boinc.berkeley.edu
-// Copyright (C) 2008 University of California
+// https://boinc.berkeley.edu
+// Copyright (C) 2026 University of California
 //
 // BOINC is free software; you can redistribute it and/or modify it
 // under the terms of the GNU Lesser General Public License
@@ -240,8 +240,8 @@ int write_init_data_file(FILE* f, APP_INIT_DATA& ai) {
         ai.proxy_info.write(mf);
     }
     ai.global_prefs.write(mf);
-    for (unsigned int i=0; i<ai.app_files.size(); i++) {
-        fprintf(f, "<app_file>%s</app_file>\n", ai.app_files[i].c_str());
+    for (const string &s: ai.app_files) {
+        fprintf(f, "<app_file>%s</app_file>\n", s.c_str());
     }
     fprintf(f, "</app_init_data>\n");
     return 0;

lib/cc_config.cpp

@@ -1,6 +1,6 @@
 // This file is part of BOINC.
 // https://boinc.berkeley.edu
-// Copyright (C) 2024 University of California
+// Copyright (C) 2026 University of California
 //
 // BOINC is free software; you can redistribute it and/or modify it
 // under the terms of the GNU Lesser General Public License
@@ -491,7 +491,7 @@ int CC_CONFIG::parse(XML_PARSER& xp, LOG_FLAGS& log_flags) {
     return ERR_XML_PARSE;
 }
 
-void EXCLUDE_GPU::write(MIOFILE& out) {
+void EXCLUDE_GPU::write(MIOFILE& out) const {
     out.printf(
         "    <exclude_gpu>\n"
         "        <url>%s</url>\n"
@@ -536,10 +536,10 @@ int CC_CONFIG::write(MIOFILE& out, LOG_FLAGS& log_flags) {
         allow_remote_gui_rpc ? 1 : 0
     );
 
-    for (i=0; i<alt_platforms.size(); ++i) {
+    for (const string &s: alt_platforms) {
         out.printf(
             "        <alt_platform>%s</alt_platform>\n",
-            alt_platforms[i].c_str()
+            s.c_str()
         );
     }
 
@@ -586,28 +586,28 @@ int CC_CONFIG::write(MIOFILE& out, LOG_FLAGS& log_flags) {
         dont_use_docker
     );
 
-    for (i=0; i<disallowed_wsls.size(); ++i) {
+    for (const string &s: disallowed_wsls) {
         out.printf(
             "        <disallowed_wsl>%s</disallowed_wsl>\n",
-            disallowed_wsls[i].c_str()
+            s.c_str()
         );
     }
 
-    for (i=0; i<exclude_gpus.size(); i++) {
-        exclude_gpus[i].write(out);
+    for (const EXCLUDE_GPU &e: exclude_gpus) {
+        e.write(out);
     }
 
-    for (i=0; i<exclusive_apps.size(); ++i) {
+    for (const string &s: exclusive_apps) {
         out.printf(
             "        <exclusive_app>%s</exclusive_app>\n",
-            exclusive_apps[i].c_str()
+            s.c_str()
         );
     }
 
-    for (i=0; i<exclusive_gpu_apps.size(); ++i) {
+    for (const string &s: exclusive_gpu_apps) {
         out.printf(
             "        <exclusive_gpu_app>%s</exclusive_gpu_app>\n",
-            exclusive_gpu_apps[i].c_str()
+            s.c_str()
         );
     }
 
@@ -632,24 +632,24 @@ int CC_CONFIG::write(MIOFILE& out, LOG_FLAGS& log_flags) {
         http_transfer_timeout_bps
     );
 
-    for (i=0; i<ignore_gpu_instance[PROC_TYPE_NVIDIA_GPU].size(); ++i) {
+    for (int d: ignore_gpu_instance[PROC_TYPE_NVIDIA_GPU]) {
         out.printf(
             "        <ignore_nvidia_dev>%d</ignore_nvidia_dev>\n",
-            ignore_gpu_instance[PROC_TYPE_NVIDIA_GPU][i]
+            d
         );
     }
 
-    for (i=0; i<ignore_gpu_instance[PROC_TYPE_AMD_GPU].size(); ++i) {
+    for (int d: ignore_gpu_instance[PROC_TYPE_AMD_GPU]) {
         out.printf(
             "        <ignore_ati_dev>%d</ignore_ati_dev>\n",
-            ignore_gpu_instance[PROC_TYPE_AMD_GPU][i]
+            d
         );
     }
 
-    for (i=0; i<ignore_gpu_instance[PROC_TYPE_INTEL_GPU].size(); ++i) {
+    for (int d: ignore_gpu_instance[PROC_TYPE_INTEL_GPU]) {
         out.printf(
             "        <ignore_intel_dev>%d</ignore_intel_dev>\n",
-            ignore_gpu_instance[PROC_TYPE_INTEL_GPU][i]
+            d
         );
     }
 
@@ -904,8 +904,7 @@ void APP_CONFIGS::write(MIOFILE& out) {
     out.printf(
         "<app_config>\n"
     );
-    for (unsigned int i=0; i<app_configs.size(); i++) {
-        APP_CONFIG& ac = app_configs[i];
+    for (const APP_CONFIG& ac: app_configs) {
         out.printf(
             "    <app>\n"
             "        <name>%s</name>\n"
@@ -925,8 +924,7 @@ void APP_CONFIGS::write(MIOFILE& out) {
             ac.report_results_immediately?1:0
         );
     }
-    for (unsigned int i=0; i<app_version_configs.size(); i++) {
-        APP_VERSION_CONFIG& avc = app_version_configs[i];
+    for (const APP_VERSION_CONFIG& avc: app_version_configs) {
         out.printf(
             "    <app_version>\n"
             "        <app_name>%s</app_name>\n"

lib/cc_config.h

@@ -1,6 +1,6 @@
 // This file is part of BOINC.
 // https://boinc.berkeley.edu
-// Copyright (C) 2024 University of California
+// Copyright (C) 2026 University of California
 //
 // BOINC is free software; you can redistribute it and/or modify it
 // under the terms of the GNU Lesser General Public License
@@ -143,7 +143,7 @@ struct EXCLUDE_GPU {
     int device_num;         // -1 means all instances
 
     int parse(XML_PARSER&);
-    void write(MIOFILE&);
+    void write(MIOFILE&) const;
 };
 
 // if you add anything here, add it to

lib/gui_rpc_client.h

@@ -1,6 +1,6 @@
 // This file is part of BOINC.
 // https://boinc.berkeley.edu
-// Copyright (C) 2023 University of California
+// Copyright (C) 2026 University of California
 //
 // BOINC is free software; you can redistribute it and/or modify it
 // under the terms of the GNU Lesser General Public License
@@ -56,7 +56,7 @@ struct GUI_URL {
     std::string url;
 
     int parse(XML_PARSER&);
-    void print();
+    void print() const;
 };
 
 // statistics at a specific day