Merge pull request #6059 from BOINC/vko_win_installer_add_registry_tests

[windows][installer] test selected registry values

Author: AenBleidd

tests/windows_installer_integration_tests.py

@@ -18,6 +18,7 @@
 import os
 import pathlib
 import sys
+import winreg
 import testset as testset
 import testhelper as testhelper
 
@@ -27,6 +28,7 @@ def __init__(self):
         self.result = True
         self.result &= self.test_version()
         self.result &= self.test_files_exist()
+        self.result &= self.test_registry_records_exist()
 
     def _get_test_executable_file_path(self, filename):
         return pathlib.Path("C:\\Program Files\\BOINC\\") / filename
@@ -37,12 +39,30 @@ def _get_test_data_file_path(self, filename):
     def _get_file_version(self, filename):
         return self.testhelper.get_version_from_string(os.popen(("\"{app}\" --version").format(app=self._get_test_executable_file_path(filename))).read().strip())
 
+    def _get_value_from_registry(self, key, value):
+        try:
+            hive, subkey = key.split("\\", 1)
+            hives = {
+                "HKEY_CLASSES_ROOT": winreg.HKEY_CLASSES_ROOT,
+                "HKEY_CURRENT_USER": winreg.HKEY_CURRENT_USER,
+                "HKEY_LOCAL_MACHINE": winreg.HKEY_LOCAL_MACHINE,
+                "HKEY_USERS": winreg.HKEY_USERS,
+                "HKEY_CURRENT_CONFIG": winreg.HKEY_CURRENT_CONFIG
+            }
+            with winreg.OpenKey(hives[hive], subkey) as key:
+                result, _ = winreg.QueryValueEx(key, value)
+                return result
+        except Exception as e:
+            print(f"Error accessing registry: {e}")
+            return None
+
     def test_version(self):
         ts = testset.TestSet("Test version is correct")
         current_version = self.testhelper.get_current_version_number()
         ts.expect_not_equal("", current_version, "Test current version could be read from the 'version.h' file")
         ts.expect_equal(current_version, self._get_file_version("boinc.exe"), "Test 'boinc.exe' version is correctly set")
         ts.expect_equal(current_version, self._get_file_version("boinccmd.exe"), "Test 'boinccmd.exe' version is correctly set")
+        ts.expect_equal(current_version, self._get_value_from_registry("HKEY_LOCAL_MACHINE\\SOFTWARE\\Space Sciences Laboratory, U.C. Berkeley\\BOINC Setup\\", "UpgradingTo"), "Test 'UpgradingTo' registry record exists and is set correctly")
         return ts.result()
 
     def test_files_exist(self):
@@ -56,6 +76,12 @@ def test_files_exist(self):
         ts.expect_true(os.path.exists(self._get_test_data_file_path("all_projects_list.xml")), "Test 'all_projects_list.xml' file exists in 'C:\\ProgramData\\BOINC\\'")
         return ts.result()
 
+    def test_registry_records_exist(self):
+        ts = testset.TestSet("Test registry records exist")
+        ts.expect_equal("C:\\ProgramData\\BOINC\\", self._get_value_from_registry("HKEY_LOCAL_MACHINE\\SOFTWARE\\Space Sciences Laboratory, U.C. Berkeley\\BOINC Setup\\", "DATADIR"), "Test 'DATADIR' registry record exists and is set correctly")
+        ts.expect_equal("C:\\Program Files\\BOINC\\", self._get_value_from_registry("HKEY_LOCAL_MACHINE\\SOFTWARE\\Space Sciences Laboratory, U.C. Berkeley\\BOINC Setup\\", "INSTALLDIR"), "Test 'INSTALLDIR' registry record exists and is set correctly")
+        return ts.result()
+
 if __name__ == "__main__":
     if not IntegrationTests().result:
         sys.exit(1)