Draft
Conversation
Author
Collaborator
|
Transitioning to New Recruit has been a plan, but one of relatively low priority for myself now as I have mostly just been performing maintenance rather than large updates. The old maintainer has been inactive since before I took over, so I doubt there will be much input on that front. At a minimum I'll look into this pull and see how far the changes affect anything. New Recruit is likely the priority going forward, both due to its improvements and the increasing adoption for the community, but I don't necessarily have to time to perform and update the repository as a whole beyond fixing issues, maintaining it, and so on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as draft to illustrate a problem:
I edited this with NewRecruit editor, and it seems to have touched every single line in the file.
Do the Konflikt47 data maintainers intend to switch to NewRecruit editor, or should this PR be re-opened from BattleScribe editor, where I assume there would be a much smaller resulting diff.
Alternately, if we wan't to cut over to NewRecruit as the "standard" editor to be used, I'm happy to open new prs on each catalog with no changes other than what NewRecruit does when saving an unchanged file.
Thoughts?