Skip to content

Comments

DRAFT - adds missing MMG to Mudskipper#19

Draft
jflo wants to merge 1 commit intoBSData:mainfrom
jflo:mudskipperFix
Draft

DRAFT - adds missing MMG to Mudskipper#19
jflo wants to merge 1 commit intoBSData:mainfrom
jflo:mudskipperFix

Conversation

@jflo
Copy link

@jflo jflo commented Apr 6, 2025

Opening as draft to illustrate a problem:

I edited this with NewRecruit editor, and it seems to have touched every single line in the file.

Do the Konflikt47 data maintainers intend to switch to NewRecruit editor, or should this PR be re-opened from BattleScribe editor, where I assume there would be a much smaller resulting diff.

Alternately, if we wan't to cut over to NewRecruit as the "standard" editor to be used, I'm happy to open new prs on each catalog with no changes other than what NewRecruit does when saving an unchanged file.

Thoughts?

@jflo jflo marked this pull request as draft April 6, 2025 02:45
@jflo
Copy link
Author

jflo commented Apr 6, 2025

soliciting feedback from @ingeanus and @amis92 as only listed "recent" committers

@ingeanus
Copy link
Collaborator

ingeanus commented Apr 8, 2025

Transitioning to New Recruit has been a plan, but one of relatively low priority for myself now as I have mostly just been performing maintenance rather than large updates. The old maintainer has been inactive since before I took over, so I doubt there will be much input on that front.

At a minimum I'll look into this pull and see how far the changes affect anything. New Recruit is likely the priority going forward, both due to its improvements and the increasing adoption for the community, but I don't necessarily have to time to perform and update the repository as a whole beyond fixing issues, maintaining it, and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants