Skip to content

Investigate if we could use setter/getters for modules #848

@ESapenaVentura

Description

@ESapenaVentura

Description of the issue

For the modules, investigate if we could use getter/setters for the properties, in order to make the classes __init__ easier to understand and expand.

Action Items

Looked up modules:

  • base_module
  • build_schema
  • config_json
    • Not sure is worth it
  • download
  • ena_upload
  • gisaid_upload
  • log_summary
  • mail
  • map
  • metadata_homogeneizer
  • pipeline_manager
  • read_bioinfo_metadata
  • read_lab_metadata
    • Para LabMetadata
  • rest_api
    • Not worth it for so little properties, but could do it
  • sftp_client
  • upload_database
  • upload_results
  • utils
  • validate
  • wrapper

Notes

  • setters apply each time a property is modified - This may break interactions between the modules. Needs to be taken into consideration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions