Skip to content

Improve sequencing instrument model mapping in read-lab-metadata to avoid ambiguity #850

@Aberdur

Description

@Aberdur

Issue Description

In the read-lab-metadata module, the mapping of the sequencing_instrument_model is currently performed using only the first word of the provided value. This approach introduces ambiguity and incorrect mappings, especially for cases such as "MinION", which by itself does not uniquely identify the sequencing platform or instrument model.

Expected Behavior

The mapping of sequencing_instrument_model should:

  • Avoid relying solely on the first word of the input value.
  • Correctly distinguish between platforms and models (e.g., MinION vs GridION vs PromethION).
  • Either:
    • Use a more robust mapping strategy (full string matching, controlled vocabulary), or
    • Explicitly detect ambiguous values and raise a clear warning or validation error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions