A round of small fixes for missing strings and version compatibility

Author: mbabker

com_podcastmanager/admin/language/en-GB/en-GB.com_podcastmanager.ini

@@ -236,3 +236,11 @@ COM_PODCASTMANAGER_VIEW_PODCAST_EDIT_PODCAST="Podcast Manager: Edit Podcast Meta
 COM_PODCASTMANAGER_VIEW_PODCAST_FIELDSET_METADATA="Podcast Metadata"
 COM_PODCASTMANAGER_VIEW_PODCASTS_TITLE="Podcast Manager: Podcasts"
 COM_PODCASTMANAGER_XML_DESCRIPTION="The Podcast Manager component is used for managing podcasts."
+
+; Overrides for strings that may not exist
+JGLOBAL_FIELD_CREATED_BY_LABEL="Created by"
+JGLOBAL_HISTORY_LIMIT_OPTIONS_DESC="The maximum number of old versions of an item to save. If zero, all old versions will be saved."
+JGLOBAL_HISTORY_LIMIT_OPTIONS_LABEL="Maximum Versions (Joomla! 3.2 and later only)"
+JGLOBAL_PUBLISHED_DATE="Published Date"
+JGLOBAL_SAVE_HISTORY_OPTIONS_DESC="Whether to automatically save old versions of an item. If set to Yes, old versions of items are saved automatically. When editing, you may restore from a previous version of the item."
+JGLOBAL_SAVE_HISTORY_OPTIONS_LABEL="Enable Versions (Joomla! 3.2 and later only)"

com_podcastmanager/site/language/en-GB/en-GB.com_podcastmanager.ini

@@ -82,3 +82,7 @@ COM_PODCASTMANAGER_OPTION_TOP="Top"
 COM_PODCASTMANAGER_PARSE_METADATA="Parse Metadata"
 COM_PODCASTMANAGER_SELECT_FEEDNAME=" - Select Feed - "
 COM_PODCASTMANAGER_TOO_MANY_MEDIA_PLUGINS="Too many media plugins are enabled, only one "_QQ_"podcastmedia"_QQ_" type plugin can be enabled.  Media path reverting to default."
+
+; Overrides for strings that may not exist
+JGLOBAL_FIELD_CREATED_BY_LABEL="Created by"
+JGLOBAL_PUBLISHED_DATE="Published Date"

com_podcastmanager/site/views/feed/tmpl/feed.php

@@ -15,13 +15,13 @@
 defined('_JEXEC') or die;
 
 // Check if user is allowed to add/edit based on component permissions.
-$canEdit = $this->feed->id && $this->user->authorise('core.edit', 'com_podcastmanager.feed.' . $this->feed->id);
+$canEdit = isset($this->feed->id) && $this->user->authorise('core.edit', 'com_podcastmanager.feed.' . $this->feed->id);
 ?>
 <div class="podcastmanager-feed<?php echo $this->pageclass_sfx;?>">
 <?php if ($this->params->def('show_page_heading', 1)) : ?>
 	<h1><?php echo $this->escape($this->params->get('page_heading')); ?></h1>
 <?php endif;
-if ($this->feed->name && $this->params->get('show_feed_title', 1)) : ?>
+if (isset($this->feed->name) && $this->params->get('show_feed_title', 1)) : ?>
 	<h2><?php echo JHtml::_('content.prepare', $this->feed->name); ?></h2>
 <?php endif;
 if ($this->params->get('show_feed_description', 1) || $this->params->get('show_feed_image', 1)) : ?>

com_podcastmanager/site/views/feed/tmpl/feed_items.php

@@ -130,7 +130,8 @@
 		</tbody>
 	</table>
 
-	<?php if (($this->params->def('show_pagination', 1) == 1  || ($this->params->get('show_pagination') == 2)) && ($this->pagination->pagesTotal > 1)) : ?>
+	<?php $paginationParam = version_compare(JVERSION, '3.0', 'lt') ? 'pages.total' : 'pagesTotal'; ?>
+	<?php if (($this->params->def('show_pagination', 1) == 1  || ($this->params->get('show_pagination') == 2)) && ($this->pagination->get($paginationParam) > 1)) : ?>
 		<div class="pagination">
 			<?php if ($this->params->def('show_pagination_results', 1)) : ?>
 			<p class="counter pull-right">

com_podcastmanager/site/views/feed/view.html.php

@@ -188,7 +188,7 @@ protected function prepareDocument($feed)
 
 		$id = (int) @$menu->query['id'];
 
-		if ($menu && ($menu->query['option'] != 'com_podcastmanager' || $id != $this->feed->id))
+		if (isset($this->feed->id) && $menu && ($menu->query['option'] != 'com_podcastmanager' || $id != $this->feed->id))
 		{
 			$this->params->set('page_subheading', $this->feed->name);
 			$path = array(array('title' => $this->feed->name, 'link' => ''));
@@ -233,13 +233,13 @@ protected function prepareDocument($feed)
 			$this->document->setMetadata('robots', $this->params->get('robots'));
 		}
 
-		if ($this->feed->author)
+		if (isset($this->feed->author))
 		{
 			$this->document->setMetaData('author', $this->feed->author);
 		}
 
 		// Add alternative feed link
-		if ($this->feed->id && $this->params->get('show_feed_link', 1) == 1)
+		if (isset($this->feed->id) && $this->params->get('show_feed_link', 1) == 1)
 		{
 			$link	= '&format=raw&layout=default&feedname=' . $this->feed->id;
 			$attribs = array('type' => 'application/rss+xml', 'title' => 'RSS 2.0');