add types in domain and remove sample.ts in sound folder

Author: Babali42

frontend/src/app/components/sequencer/sequencer.component.ts

@@ -19,8 +19,8 @@ import {SelectInputComponent} from "../select-input/select-input.component";
 })
 export class SequencerComponent implements OnInit {
   beat = {} as Beat;
-  genre = {} as  BeatsGroupedByGenre;
-  beatBehaviourSubject: Subject<Beat>;
+  genre = {} as BeatsGroupedByGenre;
+  private readonly beatBehaviourSubject: Subject<Beat>;
   genresLabel: string[] = [];
   selectedGenreLabel: string = "";
   beats: string[] = [];

frontend/src/app/domain/beat.ts

@@ -1,9 +1,9 @@
 import { Track } from "./track";
 
-export interface Beat {
-  id: string;
-  label: string;
-  bpm: number;
-  genre: string;
-  tracks: Track[];
+export type Beat = {
+  readonly id: string;
+  readonly label: string;
+  readonly bpm: number;
+  readonly genre: string;
+  readonly tracks: ReadonlyArray<Track>;
 }

frontend/src/app/domain/beatsGroupedByGenre.ts

@@ -1,6 +1,6 @@
 import {Beat} from "./beat";
 
-export interface BeatsGroupedByGenre {
-  label: string;
-  beats: Beat[];
+export type BeatsGroupedByGenre = {
+  readonly label: string;
+  readonly beats: Beat[];
 }

frontend/src/app/domain/track.ts

@@ -1,5 +1,5 @@
-export interface Track {
-  name: string;
-  fileName: string;
-  steps: boolean[];
+export type Track = {
+  readonly name: string;
+  readonly fileName: string;
+  readonly steps: boolean[];
 }

frontend/src/app/domain/sample.ts renamed to frontend/src/app/services/sound/sample.ts

@@ -1,6 +1,6 @@
 import {Injectable} from "@angular/core";
 import {Track} from "../../domain/track";
-import {Sample} from "../../domain/sample";
+import {Sample} from "./sample";
 
 @Injectable({providedIn: "root"})
 export class SoundGeneratorService {

frontend/src/app/services/sound/sound-generator.service.ts

@@ -1,5 +1,5 @@
 import {Injectable} from '@angular/core';
-import {Sample} from '../../domain/sample';
+import {Sample} from './sample';
 import {Track} from '../../domain/track';
 import {AudioFilesService} from "../files/audio-files.service";
 import {SoundGeneratorService} from "./sound-generator.service";
@@ -9,17 +9,21 @@ import {LoadingBarService} from '@ngx-loading-bar/core';
   providedIn: 'root'
 })
 export class SoundService {
-  static maxBpm = 1300;
-  static minBpm = 30;
+  private readonly audioFilesService = new AudioFilesService();
+  private readonly context: AudioContext;
+
+  static readonly maxBpm = 1300;
+  static readonly minBpm = 30;
+
   bpm: number = 120;
   isPlaying: boolean = false;
   index: number = 0;
-  private samples: Sample[] = [];
-  private context: AudioContext;
-  private tracks: Track[] = [];
-  private playbackSource: AudioBufferSourceNode;
+
+  private samples: Array<Sample> = [];
+  private tracks: Array<Track> = [];
+
   private stepNumber: number = 16;
-  private audioFilesService = new AudioFilesService();
+  private playbackSource: AudioBufferSourceNode;
   private loopBuffer: AudioBuffer | null = null;
 
   constructor(
@@ -98,8 +102,8 @@ export class SoundService {
     this.bpm = bpm;
   }
 
-  setTracks(tracks: Track[]) {
-    this.tracks = tracks;
+  setTracks(tracks: readonly Track[]) {
+    this.tracks = [...tracks];
     const trackNames = tracks.map(x => x.fileName);
     this.loadTracks(trackNames);
   }