Skip to content

Commit 58f8f14

Browse files
bkaradzic-microsoftbkaradzicCopilot
authored
Playground: sync visualization tests and reference images from Babylon.js (#1684)
Sync visualization tests + reference images from Babylon.js, plus a test-runner fix. Test config (Apps/Playground/Scripts/config.json) - Imports the full visualization test list from Babylon.js: 720 tests total (was 94). - 96 active, 624 disabled with explicit disabledReason. Three reason categories: * Pixel comparison fails on Babylon Native * Test crashes / hangs on Babylon Native * Requires WebGL2-only feature (was excludedEngines:["webgl2"] upstream) - Drops upstream's excludedEngines field (Babylon Native uses excludeFromAutomaticTesting). - Tests blocked only by excludedEngines:["webgl1"] upstream are now active here. - Stripped errorRatio from disabled tests (no effect when test doesn't run). Reference images (Apps/Playground/ReferenceImages/) - Mirrors Babylon.js/packages/tools/tests/test/visualization/ReferenceImages/, excluding WebGPU. - Re-saved as RGBA PNG with alpha channel (Babylon Native pipeline expects RGBA). Test-runner fix (Apps/Playground/Scripts/validation_native.js) - recursiveRunTest was genuinely recursive — each iteration added 3 stack frames. - At ~91 tests, Chakra threw Out of stack space, killing Win32_x64_D3D11 and Win32_x64_D3D11_Sanitizers. - Fix: defer the next iteration via setTimeout(() => recursiveRunTest(i), 0) so each test runs on a fresh stack. - setTimeout was already used elsewhere in the file (line 167), so no new dependency. CI status All 28 checks green on c512e77 (V8/JSI/Chakra D3D11, D3D12, Sanitizers, Linux JSC, Android, iOS, UWP, macOS, installations). Follow-up (out of scope) The 624 disabled tests carry actionable disabledReason strings so a follow-up PR can re-enable them as the underlying engine issues are fixed. --------- Co-authored-by: Branimir Karadzic <branimirkaradzic@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 3746203 commit 58f8f14

714 files changed

Lines changed: 4614 additions & 9 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
16.3 KB
16.4 KB
7.2 KB
3.34 KB
8.32 KB
70.8 KB
61.7 KB
7.34 KB
276 KB
276 KB

0 commit comments

Comments
 (0)