Update JsRuntimeHost to fix JSI issues

Fix broken move semantics in ExternalTexture
Pass command line arguments to google test

Author: bghgary

Apps/UnitTests/Source/App.cpp

@@ -3,9 +3,9 @@
 
 Babylon::Graphics::Configuration g_deviceConfig{};
 
-int RunTests(const Babylon::Graphics::Configuration& config)
+int RunTests(const Babylon::Graphics::Configuration& config, int argc, char* argv[])
 {
     g_deviceConfig = config;
-    testing::InitGoogleTest();
+    testing::InitGoogleTest(&argc, argv);
     return RUN_ALL_TESTS();
 }

Apps/UnitTests/Source/App.h

@@ -2,4 +2,4 @@
 
 #include <Babylon/Graphics/Device.h>
 
-int RunTests(const Babylon::Graphics::Configuration& config);
+int RunTests(const Babylon::Graphics::Configuration& config, int argc, char* argv[]);

Apps/UnitTests/Source/App_Apple.mm

@@ -2,7 +2,7 @@
 #include <Babylon/DebugTrace.h>
 #include <Metal/Metal.h>
 
-int main()
+int main(int argc, char* argv[]))
 {
     Babylon::DebugTrace::EnableDebugTrace(true);
     Babylon::DebugTrace::SetTraceOutput([](const char* trace) { NSLog(@"%s", trace); });
@@ -15,5 +15,5 @@ int main()
     config.Height = 400;
 #endif
 
-    return RunTests(config);
+    return RunTests(config, argc, argv);
 }

Apps/UnitTests/Source/App_Win32.cpp

@@ -7,7 +7,7 @@ LRESULT WINAPI WndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam)
     return ::DefWindowProc(hWnd, msg, wParam, lParam);
 }
 
-int main()
+int main(int argc, char* argv[])
 {
     SetConsoleOutputCP(CP_UTF8);
 
@@ -29,5 +29,5 @@ int main()
         OutputDebugStringA("\n");
     });
 
-    return RunTests(config);
+    return RunTests(config, argc, argv);
 }

Apps/UnitTests/Source/App_X11.cpp

@@ -16,7 +16,7 @@ namespace
     constexpr const char* wmDeleteWindowName = "WM_DELETE_WINDOW";
 }
 
-int main()
+int main(int argc, char* argv[]))
 {
     XInitThreads();
     Display* display = XOpenDisplay(NULL);
@@ -53,5 +53,5 @@ int main()
     Babylon::DebugTrace::EnableDebugTrace(true);
     Babylon::DebugTrace::SetTraceOutput([](const char* trace) { printf("%s\n", trace); fflush(stdout); });
 
-    return RunTests(config);
+    return RunTests(config, argc, argv);
 }

Apps/package-lock.json

@@ -37,7 +37,7 @@ FetchContent_Declare(ios-cmake
     GIT_TAG 4.5.0)
 FetchContent_Declare(JsRuntimeHost
     GIT_REPOSITORY https://github.com/BabylonJS/JsRuntimeHost.git
-    GIT_TAG b3dbf370caf560fb5b93936efd4cdf4e990d4d0a)
+    GIT_TAG 756bf24a179240efcd5e63590133943203546205)
 FetchContent_Declare(SPIRV-Cross
     GIT_REPOSITORY https://github.com/BabylonJS/SPIRV-Cross.git
     GIT_TAG 6abfcf066d171e9ade7604d91381ebebe4209edc)

CMakeLists.txt

@@ -69,7 +69,7 @@ namespace Babylon::Plugins
         DEBUG_TRACE("ExternalTexture [0x%p] AddToContextAsync", m_impl.get());
 
         arcana::make_task(context.BeforeRenderScheduler(), arcana::cancellation_source::none(),
-            [&context, &runtime, deferred = std::move(deferred), impl = m_impl]() {
+            [&context, &runtime, deferred = std::move(deferred), impl = m_impl]() mutable {
                 // REVIEW: The bgfx texture handle probably needs to be an RAII object to make sure it gets clean up during the asynchrony.
                 //         For example, if any of the schedulers/dispatches below don't fire, then the texture handle will leak.
                 bgfx::TextureHandle handle = bgfx::createTexture2D(impl->Width(), impl->Height(), impl->HasMips(), 1, impl->Format(), impl->Flags());
@@ -84,7 +84,7 @@ namespace Babylon::Plugins
                     return;
                 }
 
-                arcana::make_task(context.AfterRenderScheduler(), arcana::cancellation_source::none(), [&runtime, &context, deferred = std::move(deferred), handle, impl = std::move(impl)]() {
+                arcana::make_task(context.AfterRenderScheduler(), arcana::cancellation_source::none(), [&runtime, &context, deferred = std::move(deferred), handle, impl = std::move(impl)]() mutable {
                     if (bgfx::overrideInternal(handle, impl->Ptr()) == 0)
                     {
                         runtime.Dispatch([deferred = std::move(deferred), handle](Napi::Env env) {
@@ -95,7 +95,7 @@ namespace Babylon::Plugins
                         return;
                     }
 
-                    runtime.Dispatch([deferred = std::move(deferred), handle, &context, impl = std::move(impl)](Napi::Env env) {
+                    runtime.Dispatch([deferred = std::move(deferred), handle, &context, impl = std::move(impl)](Napi::Env env) mutable {
                         auto* texture = new Graphics::Texture{context};
                         DEBUG_TRACE("ExternalTexture [0x%p] attach %d x %d %d mips. Format : %d Flags : %d. (bgfx handle id %d)", impl.get(), int(impl->Width()), int(impl->Height()), int(impl->HasMips()), int(impl->Format()), int(impl->Flags()), int(handle.idx));
                         texture->Attach(handle, true, impl->Width(), impl->Height(), impl->HasMips(), 1, impl->Format(), impl->Flags());