Skip to content

Commit 925179d

Browse files
authored
Use Babylon Native's XMLHttpRequest (#94)
React Native's XMLHttpRequest uses too much memory and is too slow for use with Babylon.js. This change brings in Babylon Native's XMLHttpRequest, but does not replace the globally scoped one provided by React Native. Instead, it exposes it from the _native object, which WebRequest will specifically look for in @babylonjs/[email protected] or newer. - Update Babylon.js to 4.2.0-beta.12. - Update Babylon Native to latest (for corresponding XMLHttpRequest related changes). - Add XMLHttpRequest to the Android and iOS build. - Initialize XMLHttpRequest in the Android and iOS interop layers. - Add XMLHttpRequest related libs to the pod file and package build validation. Other unrelated changes included in this PR: - Updating some GitHub build tasks to the latest to see if it resolves some confusing build warnings. - Update iOS test app project files to use iOS 12 to match what the Babylon React Native podspec requires (otherwise I get errors when building Release in XCode 12). - Revert to the old workaround for the promise continuation issue (it turns out the new approach doesn't work on iOS in Release builds). - Add @react-native-community/cli as a dev dependency to the test apps as it seems we can use it to convert a Hermes profile to CDT profiler format and view it in Chrome (still trying to get this to work).
1 parent 61a3a8f commit 925179d

File tree

19 files changed

+725
-39
lines changed

19 files changed

+725
-39
lines changed

.github/workflows/pr.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: macos-latest
1010
steps:
1111
- name: Checkout Repo
12-
uses: actions/[email protected].1
12+
uses: actions/[email protected].3
1313
with:
1414
submodules: 'recursive'
1515
- name: Setup Ninja
@@ -28,7 +28,7 @@ jobs:
2828
runs-on: macos-latest
2929
steps:
3030
- name: Checkout Repo
31-
uses: actions/[email protected].1
31+
uses: actions/[email protected].3
3232
with:
3333
submodules: 'recursive'
3434
- name: NPM Install (Playground)

.github/workflows/publish.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
runs-on: macos-latest
99
steps:
1010
- name: Checkout Repo
11-
uses: actions/[email protected].1
11+
uses: actions/[email protected].3
1212
with:
1313
submodules: 'recursive'
1414
- name: Setup Ninja
@@ -23,7 +23,7 @@ jobs:
2323
run: npx gulp
2424
working-directory: ./Package
2525
- name: Setup Node.js
26-
uses: actions/[email protected].0
26+
uses: actions/[email protected].2
2727
with:
2828
node-version: '12.x'
2929
registry-url: 'https://registry.npmjs.org'

Apps/PackageTest/ios/PackageTest.xcodeproj/project.pbxproj

+4-5
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@
178178
D5B2C53165757B8DB1E88994 /* Pods-PackageTest-PackageTestTests.debug.xcconfig */,
179179
920AE01196CF291853BA329C /* Pods-PackageTest-PackageTestTests.release.xcconfig */,
180180
);
181-
name = Pods;
182181
path = Pods;
183182
sourceTree = "<group>";
184183
};
@@ -554,7 +553,7 @@
554553
"$(inherited)",
555554
);
556555
INFOPLIST_FILE = PackageTestTests/Info.plist;
557-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
556+
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
558557
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
559558
OTHER_LDFLAGS = (
560559
"-ObjC",
@@ -574,7 +573,7 @@
574573
BUNDLE_LOADER = "$(TEST_HOST)";
575574
COPY_PHASE_STRIP = NO;
576575
INFOPLIST_FILE = PackageTestTests/Info.plist;
577-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
576+
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
578577
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
579578
OTHER_LDFLAGS = (
580579
"-ObjC",
@@ -784,7 +783,7 @@
784783
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
785784
GCC_WARN_UNUSED_FUNCTION = YES;
786785
GCC_WARN_UNUSED_VARIABLE = YES;
787-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
786+
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
788787
LD_RUNPATH_SEARCH_PATHS = "/usr/lib/swift $(inherited)";
789788
LIBRARY_SEARCH_PATHS = (
790789
"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",
@@ -837,7 +836,7 @@
837836
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
838837
GCC_WARN_UNUSED_FUNCTION = YES;
839838
GCC_WARN_UNUSED_VARIABLE = YES;
840-
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
839+
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
841840
LD_RUNPATH_SEARCH_PATHS = "/usr/lib/swift $(inherited)";
842841
LIBRARY_SEARCH_PATHS = (
843842
"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",

0 commit comments

Comments
 (0)