fix Light export (#963)

Light export has been suffering from default auto animation set which is pin it as "dummy" node. Plus inconsitency with direction when point light or ambient

Co-authored-by: Nicholas Barlow <whoisdrigax@gmail.com>

Author: pandaGaume

Maya/Exporter/BabylonExporter.Animation.cs

@@ -44,13 +44,16 @@ private void _exporNodeAnimation(BabylonNode babylonNode, MFnTransform mFnTransf
         {
             try
             {
-                babylonNode.animations = getAnimationsFunc(mFnTransform).ToArray();
-
-                // TODO - Retreive from Maya
-                babylonNode.autoAnimate = true;
-                babylonNode.autoAnimateFrom = Loader.GetMinTime();
-                babylonNode.autoAnimateTo = Loader.GetMaxTime();
-                babylonNode.autoAnimateLoop = true;
+                var animations = getAnimationsFunc(mFnTransform).ToArray();
+                babylonNode.animations = animations != null && animations.Length != 0 ? animations : null;
+                if (babylonNode.animations != null)
+                {
+                    // TODO - Retreive from Maya
+                    babylonNode.autoAnimate = true;
+                    babylonNode.autoAnimateFrom = Loader.GetMinTime();
+                    babylonNode.autoAnimateTo = Loader.GetMaxTime();
+                    babylonNode.autoAnimateLoop = true;
+                }
             }
             catch (Exception e)
             {

Maya/Exporter/BabylonExporter.Light.cs

@@ -136,9 +136,6 @@ private BabylonNode ExportLight(MDagPath mDagPath, BabylonScene babylonScene)
             // User custom attributes
             babylonLight.metadata = ExportCustomAttributeFromTransform(mFnLightTransform);
 
-            MVector vDir = new MVector(0, 0, -1);
-            MTransformationMatrix transformationMatrix;
-
             // Animations
             if (exportParameters.exportAnimations)
             {
@@ -186,13 +183,6 @@ private BabylonNode ExportLight(MDagPath mDagPath, BabylonScene babylonScene)
                 ExportHierarchy(babylonLight, mFnLightTransform);
                 // Position / rotation / scaling
                 ExportTransform(babylonLight, mFnLightTransform);
-
-                // Direction
-                vDir = new MVector(0, 0, -1);
-                transformationMatrix = new MTransformationMatrix(mFnLightTransform.transformationMatrix);
-                vDir = vDir.multiply(transformationMatrix.asMatrixProperty);
-                vDir.normalize();
-                babylonLight.direction = new[] { (float)vDir.x, (float)vDir.y, -(float)vDir.z };
             }
 
             // Common fields 
@@ -211,6 +201,7 @@ private BabylonNode ExportLight(MDagPath mDagPath, BabylonScene babylonScene)
                     babylonLight.type = 2;
                     babylonLight.angle = (float)mFnSpotLight.coneAngle;
                     babylonLight.exponent = 1;
+                    babylonLight.direction = ComputeDirection(mFnLightTransform, new MVector(0, 0, -1));
 
                     if (mFnSpotLight.useDecayRegions)
                     {
@@ -219,6 +210,7 @@ private BabylonNode ExportLight(MDagPath mDagPath, BabylonScene babylonScene)
                     break;
                 case MFn.Type.kDirectionalLight:
                     babylonLight.type = 1;
+                    babylonLight.direction = ComputeDirection(mFnLightTransform, new MVector(0, 0, -1));
                     break;
                 case MFn.Type.kAmbientLight:
                     babylonLight.type = 3;
@@ -231,11 +223,7 @@ private BabylonNode ExportLight(MDagPath mDagPath, BabylonScene babylonScene)
                     // Direction
                     if (!createDummy)
                     {
-                        vDir = new MVector(0, 1, 0);
-                        transformationMatrix = new MTransformationMatrix(mFnLightTransform.transformationMatrix);
-                        vDir = vDir.multiply(transformationMatrix.asMatrixProperty);
-                        vDir.normalize();
-                        babylonLight.direction = new[] { (float)vDir.x, (float)vDir.y, -(float)vDir.z };
+                        babylonLight.direction = ComputeDirection(mFnLightTransform, new MVector(0, 1, 0));
                     }
                     break;
                 case MFn.Type.kAreaLight:
@@ -293,5 +281,14 @@ private bool IsLightExportable(MFnDagNode mFnDagNode, MDagPath mDagPath)
         {
             return IsNodeExportable(mFnDagNode, mDagPath);
         }
-    }
+
+        private float[] ComputeDirection(MFnTransform mFnLightTransform, MVector vDir)
+        {
+            var transformationMatrix = new MTransformationMatrix(mFnLightTransform.transformationMatrix);
+            vDir = vDir.multiply(transformationMatrix.asMatrixProperty);
+            vDir.normalize();
+            return new[] { (float)vDir.x, (float)vDir.y, -(float)vDir.z };
+        }
+
+}
 }