Skip to content

Commit 6346a2f

Browse files
committed
Upgrade to Node 24
There isn't any reason to use anything but active node, as far as I can tell.
1 parent bfa92e5 commit 6346a2f

File tree

7 files changed

+25
-22
lines changed

7 files changed

+25
-22
lines changed

.node-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
24

AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# QA Instructions Action
22

3-
A GitHub Action (TypeScript + Node 20) that generates QA instructions.
3+
A GitHub Action (TypeScript + Node 24) that generates QA instructions.
44

55
## Build Commands
66

@@ -19,4 +19,4 @@ A GitHub Action (TypeScript + Node 20) that generates QA instructions.
1919
- **Strict TypeScript**`tsconfig.json` has `strict: true`. Do not use `any` without justification.
2020
- **Lint and format before committing** — run `npm run lint` and `npm run format:check` before creating a commit.
2121
- **Source lives in `src/`** — all TypeScript source code is in the `src/` directory. The `lib/` directory is intermediate compiler output and is git-ignored.
22-
- **Node version** — defined in `.node-version` and must match the `runs.using` runtime in `action.yml`. When updating Node, change `.node-version`, `action.yml` (`runs.using`), and `@types/node` in `package.json` together.
22+
- **Node version**this project uses the active Node.js version supported by GitHub Actions (currently Node 24). The version is defined in `.node-version` and must match the `runs.using` runtime in `action.yml`. When updating Node, change `.node-version`, `action.yml` (`runs.using`), `@types/node` in `package.json`, and `@tsconfig/nodeXX` in both `package.json` and `tsconfig.json` together.

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,13 +155,16 @@ npm install
155155

156156
### Node Version
157157

158-
The Node version is defined in `.node-version` and must match the `runs.using` runtime in `action.yml`. GitHub Actions only supports specific Node runtimes (`node20`, `node24`, etc.). When updating, change all three locations together:
158+
This project follows a policy of using the active Node.js version supported by GitHub Actions. The Node version is defined in `.node-version` and must match the `runs.using` runtime in `action.yml`. GitHub Actions only supports specific Node runtimes (`node20`, `node24`, etc.).
159+
160+
When updating to a new Node version, change all four locations together:
159161

160162
1. `.node-version`
161163
2. `action.yml` → `runs.using`
162164
3. `@types/node` version in `package.json`
165+
4. `@tsconfig/nodeXX` version in `package.json` and `tsconfig.json`
163166

164-
Currently using **Node 20**. GitHub plans to deprecate `node20` in favor of `node24` in March 2026.
167+
**Current version: Node 24**
165168

166169
### Making Changes
167170

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ outputs:
2525
instructions:
2626
description: "The generated QA instructions"
2727
runs:
28-
using: "node20"
28+
using: "node24"
2929
main: "dist/index.js"

package-lock.json

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
},
2626
"devDependencies": {
2727
"@eslint/js": "^10.0.1",
28-
"@tsconfig/node20": "^20.1.9",
29-
"@types/node": "^20",
28+
"@tsconfig/node24": "^24.0.4",
29+
"@types/node": "^24",
3030
"esbuild": "^0.27.3",
3131
"eslint": "^10",
3232
"eslint-config-prettier": "^10",

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "@tsconfig/node20/tsconfig.json",
2+
"extends": "@tsconfig/node24/tsconfig.json",
33
"compilerOptions": {
44
"rootDir": "./src",
55
"outDir": "./lib",

0 commit comments

Comments
 (0)