feat(config): replace askToContinue with onSessionEnd for session-end behavior

Author: timrekelj

README.md

@@ -132,9 +132,9 @@ pomo looks for its config file in the following order:
 Example `pomo.yaml`:
 
 ```yaml
-# prompt to continue after session completion
-# false = exit when done
-askToContinue: true
+# Action to take after session completion
+# available options: (ask, skip, quit)
+onSessionEnd: "ask"
 
 asciiArt:
   # use ASCII art for timer display

cmd/runner.go

@@ -22,7 +22,7 @@ func runTask(taskType config.TaskType, cmd *cobra.Command) {
 
 	log.Printf("starting %v session: %v", taskType.GetTask().Title, taskType.GetTask().Duration)
 
-	m := ui.NewModel(taskType, config.C.ASCIIArt, config.C.AskToContinue)
+	m := ui.NewModel(taskType, config.C.ASCIIArt, config.C.OnSessionEnd)
 	p := tea.NewProgram(m, tea.WithAltScreen())
 
 	finalModel, err := p.Run()

config/config.go

@@ -45,10 +45,10 @@ type ASCIIArt struct {
 }
 
 type Config struct {
-	Work          Task
-	Break         Task
-	AskToContinue bool
-	ASCIIArt      ASCIIArt
+	Work         Task
+	Break        Task
+	OnSessionEnd string
+	ASCIIArt     ASCIIArt
 }
 
 var (
@@ -57,7 +57,7 @@ var (
 	C    Config
 
 	DefaultConfig = map[string]any{
-		"askToContinue": true,
+		"onSessionEnd": "ask",
 		"asciiArt": map[string]any{
 			"enabled": true,
 			"font":    ascii.DefaultFont,

config/config_test.go

@@ -19,7 +19,7 @@ func TestMain(m *testing.M) {
 
 func TestLoadConfig(t *testing.T) {
 	testConfig := `
-askToContinue: true
+onSessionEnd: ask
 work:
   duration: 31m
   title: custom work
@@ -28,7 +28,7 @@ work:
 	setupViper()
 	writeAndLoadConfig(t, testConfig)
 
-	assert.True(t, C.AskToContinue, "AskToContinue should be true")
+	assert.Equal(t, "ask", C.OnSessionEnd, "OnSessionEnd should be 'ask'")
 	assert.Equal(t, 31*time.Minute, C.Work.Duration, "Work duration should be 31 minutes")
 	assert.Equal(t, "custom work", C.Work.Title, "Work title should be 'custom work'")
 }
@@ -46,7 +46,7 @@ func TestLoadConfigDefaults(t *testing.T) {
 
 func TestLoadConfigPartialUpdate(t *testing.T) {
 	partialConfig := `
-askToContinue: true
+onSessionEnd: ask
 work:
   duration: 30m
   title: custom work
@@ -58,7 +58,7 @@ asciiArt:
 	writeAndLoadConfig(t, partialConfig)
 
 	// test overridden values
-	assert.True(t, C.AskToContinue, "AskToContinue should be true")
+	assert.Equal(t, "ask", C.OnSessionEnd, "OnSessionEnd should be 'ask'")
 	assert.Equal(t, 30*time.Minute, C.Work.Duration, "Work duration should be 30 minutes")
 	assert.Equal(t, "custom work", C.Work.Title, "Work title should be 'custom work'")
 	assert.Equal(t, "#FF0000", C.ASCIIArt.Color, "ASCII art color should be '#FF0000'")
@@ -96,7 +96,7 @@ work:
 
 func TestLoadConfigAllFieldsComprehensive(t *testing.T) {
 	configYAML := `
-askToContinue: true
+onSessionEnd: ask
 asciiArt:
   enabled: true
   font: ansi
@@ -130,7 +130,7 @@ break:
 	writeAndLoadConfig(t, configYAML)
 
 	// main config
-	assert.True(t, C.AskToContinue, "AskToContinue should be true")
+	assert.Equal(t, "ask", C.OnSessionEnd, "OnSessionEnd should be 'ask'")
 
 	// ASCII art
 	assert.True(t, C.ASCIIArt.Enabled, "ASCII art should be enabled")
@@ -274,7 +274,7 @@ func getDefaultConfig() Config {
 // assertConfigMatches validates all fields between expected and actual config
 func assertConfigMatches(t *testing.T, expected Config, actual Config) {
 	// main config assertion
-	assert.Equal(t, expected.AskToContinue, actual.AskToContinue)
+	assert.Equal(t, expected.OnSessionEnd, actual.OnSessionEnd)
 
 	// ASCII Art assertions
 	assert.Equal(t, expected.ASCIIArt.Enabled, actual.ASCIIArt.Enabled)

config/schema.json

@@ -5,10 +5,11 @@
   "description": "Configuration schema for pomo - Terminal Pomodoro Timer",
   "type": "object",
   "properties": {
-    "askToContinue": {
-      "type": "boolean",
-      "description": "Prompt to continue after completion (false = exit when done)",
-      "default": true
+    "onSessionEnd": {
+      "type": "string",
+      "description": "Action to take when session ends",
+      "enum": ["ask", "skip", "quit"],
+      "default": "ask"
     },
     "asciiArt": {
       "type": "object",

pomo.yaml

@@ -2,7 +2,7 @@
 # pomo config file
 # https://github.com/Bahaaio/pomo
 
-askToContinue: true
+onSessionEnd: "ask"
 
 asciiArt:
   enabled: true

ui/handlers.go

@@ -145,19 +145,24 @@ func (m *Model) handleCompletion() tea.Cmd {
 	m.recordSession()
 	actions.RunPostActions(&m.currentTask).Wait()
 
-	// show confirmation dialog if configured to do so
-	if m.shouldAskToContinue {
+	// continue after the completion according to config
+	switch m.onSessionEnd {
+	case "ask":
 		m.sessionState = ShowingConfirm
 		m.confirmStartTime = time.Now()
 
 		// send first confirm tick
 		return func() tea.Msg {
 			return confirmTickMsg{}
 		}
+	case "skip":
+		return m.nextSession()
+	case "quit":
+		return m.Quit()
+	default:
+		log.Printf("unknown onSessionEnd value %q, defaulting to quit", m.onSessionEnd)
+		return m.Quit()
 	}
-
-	// else, quit
-	return m.Quit()
 }
 
 // starts session with the opposite task type (work <-> break)

ui/model.go

@@ -28,14 +28,14 @@ type Model struct {
 	elapsed  time.Duration
 
 	// state
-	width, height       int // window dimensions
-	shouldAskToContinue bool
-	sessionState        SessionState
-	confirmStartTime    time.Time
-	currentTaskType     config.TaskType
-	currentTask         config.Task
-	sessionSummary      summary.SessionSummary
-	isShortSession      bool
+	width, height    int // window dimensions
+	onSessionEnd     string
+	sessionState     SessionState
+	confirmStartTime time.Time
+	currentTaskType  config.TaskType
+	currentTask      config.Task
+	sessionSummary   summary.SessionSummary
+	isShortSession   bool
 
 	// ASCII art
 	useTimerArt     bool
@@ -46,7 +46,7 @@ type Model struct {
 	repo *db.SessionRepo
 }
 
-func NewModel(taskType config.TaskType, asciiArt config.ASCIIArt, askToContinue bool) Model {
+func NewModel(taskType config.TaskType, asciiArt config.ASCIIArt, onSessionEnd string) Model {
 	task := taskType.GetTask()
 
 	var timerFont ascii.Font
@@ -83,11 +83,11 @@ func NewModel(taskType config.TaskType, asciiArt config.ASCIIArt, askToContinue
 		timer:    timer.New(task.Duration),
 		duration: task.Duration,
 
-		shouldAskToContinue: askToContinue,
-		sessionState:        Running,
-		currentTaskType:     taskType,
-		currentTask:         *task,
-		sessionSummary:      sessionSummary,
+		onSessionEnd:    onSessionEnd,
+		sessionState:    Running,
+		currentTaskType: taskType,
+		currentTask:     *task,
+		sessionSummary:  sessionSummary,
 
 		useTimerArt:     asciiArt.Enabled,
 		timerFont:       timerFont,