Fix not to send unnecessary IBusAttribute

fujiwarat · fujiwarat · commit 5e7c380f8ff4 · 2025-10-10T10:26:59.000+09:00
When a GTK3 application is used with GTK_IM_MODULE=ibus, it
outputs many warnings.
diff --git a/engine_preedit.go b/engine_preedit.go
@@ -110,9 +110,7 @@ func (e *IBusBambooEngine) updatePreedit(processedStr string) {
 		return
 	}
 
-	if e.config.IBflags&config.IBnoUnderline != 0 {
-		ibusText.AppendAttr(ibus.IBUS_ATTR_TYPE_NONE, ibus.IBUS_ATTR_UNDERLINE_SINGLE, 0, preeditLen)
-	} else {
+	if e.config.IBflags&config.IBnoUnderline == 0 {
 		ibusText.AppendAttr(ibus.IBUS_ATTR_TYPE_UNDERLINE, ibus.IBUS_ATTR_UNDERLINE_SINGLE, 0, preeditLen)
 	}
 	e.UpdatePreeditTextWithMode(ibusText, preeditLen, true, ibus.IBUS_ENGINE_PREEDIT_COMMIT)

Original file line number	Diff line number	Diff line change
`@@ -110,9 +110,7 @@ func (e *IBusBambooEngine) updatePreedit(processedStr string) {`
`110`	`110`	`return`
`111`	`111`	`}`
`112`	`112`
`113`		`- if e.config.IBflags&config.IBnoUnderline != 0 {`
`114`		`- ibusText.AppendAttr(ibus.IBUS_ATTR_TYPE_NONE, ibus.IBUS_ATTR_UNDERLINE_SINGLE, 0, preeditLen)`
`115`		`- } else {`
	`113`	`+ if e.config.IBflags&config.IBnoUnderline == 0 {`
`116`	`114`	`ibusText.AppendAttr(ibus.IBUS_ATTR_TYPE_UNDERLINE, ibus.IBUS_ATTR_UNDERLINE_SINGLE, 0, preeditLen)`
`117`	`115`	`}`
`118`	`116`	`e.UpdatePreeditTextWithMode(ibusText, preeditLen, true, ibus.IBUS_ENGINE_PREEDIT_COMMIT)`